Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Nikolay Sivov
On 2/26/2010 19:17, Alexandre Julliard wrote: Nikolay Sivov writes: On 2/26/2010 19:00, Alexandre Julliard wrote: I'm not saying that you should remove it, but that you should set last error to 0xdeadbeef to make it clear whether you are expecting it to be unchanged or set to 0. Rig

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Alexandre Julliard
Nikolay Sivov writes: > On 2/26/2010 19:00, Alexandre Julliard wrote: >> I'm not saying that you should remove it, but that you should set last >> error to 0xdeadbeef to make it clear whether you are expecting it to be >> unchanged or set to 0. Right now your test could mean either. >> > Prev

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Nikolay Sivov
On 2/26/2010 19:00, Alexandre Julliard wrote: Nikolay Sivov writes: On 2/26/2010 16:38, Alexandre Julliard wrote: Nikolay Sivov writes: @@ -626,15 +627,22 @@ static void test_query_value_ex(void) trace("test_query_value_ex: type set to: 0x%08x\n", type);

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Alexandre Julliard
Nikolay Sivov writes: > On 2/26/2010 16:38, Alexandre Julliard wrote: >> Nikolay Sivov writes: >> >> >>> @@ -626,15 +627,22 @@ static void test_query_value_ex(void) >>> trace("test_query_value_ex: type set to: 0x%08x\n", type); >>> ok(size == 0, "size should have been set

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Nikolay Sivov
On 2/26/2010 16:38, Alexandre Julliard wrote: Nikolay Sivov writes: @@ -626,15 +627,22 @@ static void test_query_value_ex(void) trace("test_query_value_ex: type set to: 0x%08x\n", type); ok(size == 0, "size should have been set to 0 instead of %d\n", size); } +

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Alexandre Julliard
Nikolay Sivov writes: > @@ -626,15 +627,22 @@ static void test_query_value_ex(void) > trace("test_query_value_ex: type set to: 0x%08x\n", type); > ok(size == 0, "size should have been set to 0 instead of %d\n", > size); > } > +todo_wine ok(GetLastError() == ERROR_SUCCE