Re: add tests to odbccp32

2007-01-09 Thread Alexandre Julliard
Bill Medland <[EMAIL PROTECTED]> writes: > +/* MSDN states that the error number should be between 1 and 8. Passing > 0 is an error */ > +sql_ret = SQLInstallerError(0, NULL, NULL, 0, NULL); > +todo_wine(sql_ret == SQL_ERROR, "SQLInstallerError(0...) failed with %d > instead of SQL_

Re: Add tests to odbccp32

2007-01-08 Thread Detlef Riekenberg
On Mo, 2007-01-08 at 09:58 -0800, Bill Medland wrote: > Bill Medland ([EMAIL PROTECTED]) > Add tests structure to odbccp32 > +START_TEST(error) > +{ > +} We really need more tests, but I do not think, that an empty testfile can go in the tree. And as another hint, you should use the same filename

Re: Add tests to odbccp32

2007-01-08 Thread James Hawkins
On 1/8/07, Bill Medland <[EMAIL PROTECTED]> wrote: On Mon, 2007-08-01 at 12:38 -0600, James Hawkins wrote: > On 1/8/07, Bill Medland <[EMAIL PROTECTED]> wrote: > > On Mon, 2007-08-01 at 12:11 -0600, James Hawkins wrote: > > > On 1/8/07, Bill Medland <[EMAIL PROTECTED]> wrote: > > > > Bill Medland

Re: Add tests to odbccp32

2007-01-08 Thread Bill Medland
On Mon, 2007-08-01 at 12:38 -0600, James Hawkins wrote: > On 1/8/07, Bill Medland <[EMAIL PROTECTED]> wrote: > > On Mon, 2007-08-01 at 12:11 -0600, James Hawkins wrote: > > > On 1/8/07, Bill Medland <[EMAIL PROTECTED]> wrote: > > > > Bill Medland ([EMAIL PROTECTED]) > > > > Add tests structure to o

Re: Add tests to odbccp32

2007-01-08 Thread James Hawkins
On 1/8/07, Bill Medland <[EMAIL PROTECTED]> wrote: On Mon, 2007-08-01 at 12:11 -0600, James Hawkins wrote: > On 1/8/07, Bill Medland <[EMAIL PROTECTED]> wrote: > > Bill Medland ([EMAIL PROTECTED]) > > Add tests structure to odbccp32 > > > > You need to add tests for this patch to be accepted. Al

Re: Add tests to odbccp32

2007-01-08 Thread Bill Medland
On Mon, 2007-08-01 at 12:11 -0600, James Hawkins wrote: > On 1/8/07, Bill Medland <[EMAIL PROTECTED]> wrote: > > Bill Medland ([EMAIL PROTECTED]) > > Add tests structure to odbccp32 > > > > You need to add tests for this patch to be accepted. Also, you've > labeled the test suite 'error'. How ma

Re: Add tests to odbccp32

2007-01-08 Thread James Hawkins
On 1/8/07, Bill Medland <[EMAIL PROTECTED]> wrote: Bill Medland ([EMAIL PROTECTED]) Add tests structure to odbccp32 You need to add tests for this patch to be accepted. Also, you've labeled the test suite 'error'. How many functions in odbccp32 are you planning on testing in this file? I se