Re: add autodetect audio driver capability to winmm, second try

2004-07-29 Thread Alexandre Julliard
James Hawkins <[EMAIL PROTECTED]> writes: > +/* try to detect arts */ > +argv_new[2] = "ps awx|grep artsd|grep -v grep|grep artsd > /dev/null"; > +if(!spawnvp(_P_WAIT, "/bin/sh", argv_new)) > +{ > +driversFound[numFound] = "winearts.drv"; > +name[numFound] = "aRts";

Re: add autodetect audio driver capability to winmm

2004-07-25 Thread Marcus Meissner
On Sun, Jul 25, 2004 at 05:08:04PM -0500, James Hawkins wrote: > Changelog: > * take audio autodetection out of winecfg and put it in winmm > * if driver is not found in the registry or the driver fails to > load, then autodetect driver This would make artsd the default driver on KDE syste

Re: add autodetect audio driver capability to winmm

2004-07-25 Thread Francois Gouget
On Mon, 26 Jul 2004, Robert Shearman wrote: [...] > >Actually this is the start of a block of code since the character > >preceeding 'BOOL' is '{'. > > Not quite. After applying the patch, this is what you get: Ah, sorry. It the '-' I missed. -- Francois Gouget [EMAIL PROTECTED]

Re: add autodetect audio driver capability to winmm

2004-07-25 Thread Robert Shearman
Francois Gouget wrote: On Mon, 26 Jul 2004, Robert Shearman wrote: [...] size = sizeof(buffer); -if (!RegQueryValueExA(hKey, "Drivers", 0, &type, (LPVOID)buffer, &size)) { +BOOL keyQueried = !RegQueryValueExA(hKey, "Drivers", 0, &type, - all variable declarat

Re: add autodetect audio driver capability to winmm

2004-07-25 Thread Francois Gouget
On Mon, 26 Jul 2004, Robert Shearman wrote: [...] > >>>size = sizeof(buffer); > >>>-if (!RegQueryValueExA(hKey, "Drivers", 0, &type, (LPVOID)buffer, &size)) { > >>>+BOOL keyQueried = !RegQueryValueExA(hKey, "Drivers", 0, &type, > >>> > - all variable declarations must b

Re: add autodetect audio driver capability to winmm

2004-07-25 Thread Robert Shearman
James Hawkins wrote: This is only available in C99. We try to make Wine compile with as many C compilers as possible, including gcc 2.95, which doesn't allow this sort of thing. What part of the code is only availabe in C99? I'll try to fix it so we can be compatible with other compilers.

Re: add autodetect audio driver capability to winmm

2004-07-25 Thread Mike Hearn
On Sun, 25 Jul 2004 17:33:19 -0500, James Hawkins wrote: > What part of the code is only availabe in C99? I'll try to fix it so > we can be compatible with other compilers. You can't declare variables in the middle of a block. They have to go at the start.

Re: add autodetect audio driver capability to winmm

2004-07-25 Thread James Hawkins
> This is only available in C99. We try to make Wine compile with as many > C compilers as possible, including gcc 2.95, which doesn't allow this > sort of thing. What part of the code is only availabe in C99? I'll try to fix it so we can be compatible with other compilers. On Sun, 25 Jul 2004 23

Re: add autodetect audio driver capability to winmm

2004-07-25 Thread Robert Shearman
James Hawkins wrote: Changelog: * take audio autodetection out of winecfg and put it in winmm * if driver is not found in the registry or the driver fails to load, then autodetect driver Thanks for another cool patch. It lessens the burden on the user. CC'ing ros-kernel as explained below.