Re: abort if WINEDEBUG requests functionality that was disabled at configure time

2006-04-16 Thread Tomas Carnecky
Segin wrote: > Mike Hearn wrote: >> On Sat, 15 Apr 2006 23:37:17 -0400, Mike Frysinger wrote: >> >>> if wine is built with --disable-trace or --disable-debug, then using >>> WINEDEBUG >>> will accept the respective options without complaining and without actually >>> showing any useful inform

Re: abort if WINEDEBUG requests functionality that was disabled at configure time

2006-04-16 Thread Segin
Mike Hearn wrote: On Sat, 15 Apr 2006 23:37:17 -0400, Mike Frysinger wrote: if wine is built with --disable-trace or --disable-debug, then using WINEDEBUG will accept the respective options without complaining and without actually showing any useful information Why wou

Re: abort if WINEDEBUG requests functionality that was disabled at configure time

2006-04-16 Thread Alexandre Julliard
Lionel Ulmer <[EMAIL PROTECTED]> writes: > So if I take your reasonning further, why even keep the '--disable-debug' / > '--disable-trace' options in the configure script ? In fact, I think removing them would be a good idea. People who absolutely want to build a broken Wine can always define the

Re: abort if WINEDEBUG requests functionality that was disabled at configure time

2006-04-16 Thread Mike Hearn
On Sun, 16 Apr 2006 15:10:28 +0200, Lionel Ulmer wrote: > So if I take your reasonning further, why even keep the '--disable-debug' / > '--disable-trace' options in the configure script ? Well, I do wonder ... I guess for specialist scenarios some #define in the source would be just as good. >

Re: abort if WINEDEBUG requests functionality that was disabled at configure time

2006-04-16 Thread Lionel Ulmer
On Sun, Apr 16, 2006 at 01:55:11PM +0100, Mike Hearn wrote: > So, I'll say it again - can somebody prove that Wine is faster without > the tracing? I doubt it. And if there is a region where the debug > channel test slows things down we can always add manual branch > prediction hints or just take t

Re: abort if WINEDEBUG requests functionality that was disabled at configure time

2006-04-16 Thread Mike Hearn
On 4/16/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: > I know the overhead of an dispatch table is bigger > than a simple 'if (trace) {}', but this few (load, compare == two?) > additional instruction still is noticeable in certain applications. The overhead of a dispatch table is *much* bigger -

Re: abort if WINEDEBUG requests functionality that was disabled at configure time

2006-04-16 Thread Tomas Carnecky
Mike Hearn wrote: > Why would anybody build without tracing anyway? I would be *very* > surprised if it led to any noticable/real world performance improvement. Because of the exact same reason NVidia doesn't want to add yet another dispatch table to linux's OpenGL libraries (as proposed by someon

Re: abort if WINEDEBUG requests functionality that was disabled at configure time

2006-04-16 Thread Mike Hearn
On Sat, 15 Apr 2006 23:37:17 -0400, Mike Frysinger wrote: > if wine is built with --disable-trace or --disable-debug, then using > WINEDEBUG > will accept the respective options without complaining and without actually > showing any useful information Why would anybody build without tracing any