Re: X11DRV: GetKeyNameTextW returns a wrong length

2008-11-30 Thread Vitaliy Margolen
Vincent Povirk wrote: >> --- keyboard.old2008-11-27 16:53:15.0 +0100 >> +++ keyboard.c2008-11-26 21:19:01.0 +0100 All patches have to be generated from the top of the source tree (if you not using git). This patch is invalid. Vitaliy

Re: X11DRV: GetKeyNameTextW returns a wrong length

2008-11-30 Thread Vincent Povirk
I don't think "lpBuffer[nSize - 1] = 0;" is safe to remove. If nSize is too small, the resulting string may not be NULL-terminated. Patch-sending guidelines are at http://www.winehq.org/site/sending_patches. Your patch is more likely to be committed if you write a conformance test (although it ma