Re: Wrong charcter encoding in winmm-tests

2012-02-26 Thread Francois Gouget
On Sun, 26 Feb 2012, Julian Rüger wrote: [...] > Then shouldn't most or all of those CP_ACPs (and CP_UTF8s) be replaced > with CP_UNIXCP? No. As I said, all the functions that end with an 'A' are supposed to return ANSI strings and thus must use CP_ACP. Remember that Wine is a Win32 API reimplem

Re: Wrong charcter encoding in winmm-tests

2012-02-26 Thread Julian Rüger
> So I think it's the test that should be performing the apprpriate > conversion (assuming we really care) but I can't remember the details I suppose everyone running the tests should be able to figure it out and set $LANG to en_US or something for the test. But I think this is more widespread:

Re: Wrong charcter encoding in winmm-tests

2012-02-26 Thread Francois Gouget
On Sun, 26 Feb 2012, Julian Rüger wrote: > OK, I think I finally found out what's going on here: > > in waveform.c waveOutGetErrorTextA() calls > WideCharToMultiByte(CP_ACP, with the ANSI codepage. > When I change that to CP_UTF8, it works as expected. > > Is this fix OK, or does that break

Re: Wrong charcter encoding in winmm-tests

2012-02-26 Thread Julian Rüger
OK, I think I finally found out what's going on here: in waveform.c waveOutGetErrorTextA() calls WideCharToMultiByte(CP_ACP, with the ANSI codepage. When I change that to CP_UTF8, it works as expected. Is this fix OK, or does that break anything? Should I send a patch? Thanks, Julian

Re: Wrong charcter encoding in winmm-tests

2012-02-26 Thread Julian Rüger
> waveOutGetErrorTextA() if I am not mistaken. Forget that part please ;) So, the .po is UTF-8, the terminal is UTF-8 and my $LANG is de_DE.UTF-8, but somewhere it is converted to 8859-1...

Wrong charcter encoding in winmm-tests

2012-02-26 Thread Julian Rüger
Hello everyone, I ran the winmm-tests in wine today, with a german locale, and noticed that the umlauts are displayed incorrectly. My terminal is in UTF-8 and wine outputs ISO 8859-1. I looked into the code and found out that ie. in wave.c, wave_out_error() declares the strings as static char, an