Am Donnerstag, 26. Mai 2005 11:13 schrieb Dimi Paun:
> On Thu, 2005-05-26 at 12:40 +, Stefan Dösinger wrote:
> > patch -p 1 -R < /home/stefan/Desktop/shell32.diff(Just to test if
>
>
> patch -p0 -R <
That's it, thanks
On Thu, 2005-05-26 at 12:40 +, Stefan Dösinger wrote:
> patch -p 1 -R < /home/stefan/Desktop/shell32.diff(Just to test if
patch -p0 -R <
--
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.
On Thursday 26 May 2005 14:40, Stefan Dösinger wrote:
> I created the diffs from the wine root, and I apply the patches in the
> sources root directory. If I specify the filedlls/shell32/shfldr_desktop.c,
> the patch applies fine.
You should create as well as apply the patches in the top level win
> First, I would move the psfParent and rpidl variable declarations into the
> then-branch of the if statement, since this is the only place they are
> used. But this is of course personal preference.
Good, done so. I always thought this was a C++ invention.
> Second, please use the -pu flags when
On Thursday 26 May 2005 13:18, Stefan Dösinger wrote:
> Any further suggestions? If not, I'll modify the other shflrds and send a
> patch to wine-patches ;-)
Looks good to me.
Two style things:
First, I would move the psfParent and rpidl variable declarations into the
then-branch of the if st
Hi,
> I meant that you should remove the dwAttributes member from
> IGenericFSFolder and call SHELL32_GetItemAttributes in shfldr_fs's
> GetAttributesOf method passing the rfgInOut parameter. You don't have to
> modify the Initialize[Ex] methods.
>
> That said, this is the preferable option in my o
On Wednesday 25 May 2005 20:38, Stefan Dösinger wrote:
> Just a question if I understood that correctly
> So PidlRoot represents a list of Folders, from the root to the current
> folder. For C:\somedir\dirx this would more or less mean
> C:\
> somedir\
> dirx\
Yes, that's correct.
> Can I use pid
Hi,
> Hi Stefan,
>
> On Wednesday 25 May 2005 18:13, Stefan Dösinger wrote:
> > Any suggestions to the following patch?
>
> + SHELL32_GetItemAttributes (_IShellFolder_ (This), This->pidlRoot,
> &dwAttributes);
>
> This->pidlRoot is the ITEMIDLIST of all SHITEMIDs starting from the root of
> the sh
Hi Stefan,
On Wednesday 25 May 2005 18:13, Stefan Dösinger wrote:
> Any suggestions to the following patch?
+ SHELL32_GetItemAttributes (_IShellFolder_ (This), This->pidlRoot,
&dwAttributes);
This->pidlRoot is the ITEMIDLIST of all SHITEMIDs starting from the root of
the shell namespace up t
Am Dienstag, 24. Mai 2005 21:40 schrieb Juan Lang:
> --- Stefan Dösinger <[EMAIL PROTECTED]> wrote:
> > Checking against This->pidlRoot makes writing work.
>
>
>
> > Is the attached patch correct?
>
> That appears as if it would work. Although I must say my curiosity isn't
> quite satisfied. The
--- Stefan Dösinger <[EMAIL PROTECTED]> wrote:
> Checking against This->pidlRoot makes writing work.
> Is the attached patch correct?
That appears as if it would work. Although I must say my curiosity isn't
quite satisfied. There's the comment in shlfldr_fs.c about dwAttributes,
saying it shoul
On Tuesday 24 May 2005 22:45, Stefan Dösinger wrote:
> Is the attached patch correct? I am not sure because I don't know much
> about these things, so I am not submitting it to wine-patches yet.
> Any suggestions?
Just realized that there's still a problem with your patch. At the moment, you
are
On Tuesday 24 May 2005 22:45, Stefan Dösinger wrote:
> On an write-protected
> folder, this check still succeeds(the read-only flag is removed).
This is from ntdll/directory, line 792:
if (!(st.st_mode & (S_IWUSR | S_IWGRP | S_IWOTH)))
info->FileAttributes |= FILE_ATTRIBUTE_READONLY;
So the
Am Dienstag, 24. Mai 2005 17:10 schrieb Juan Lang:
> Hi Stefan,
>
> --- Stefan Dösiner <[EMAIL PROTECTED]> wrote:
> > How do I handle apidl == NULL? As far as I understand, apidl specifies a
> > list
> > of folders/files to be checked, right? If apidl == 0, what folder should
> > I
> > check. Is th
Hi Stefan,
--- Stefan Dösiner <[EMAIL PROTECTED]> wrote:
> How do I handle apidl == NULL? As far as I understand, apidl specifies a
> list
> of folders/files to be checked, right? If apidl == 0, what folder should
> I
> check. Is there some 'current folder' in the IShellFolder class? I
> didn't
Stefan wrote:
> There's a check for this case:
> if (cidl && !apidl)
> return E_INVALIDARG;
>
> MSDN doesn't give me a hint what to do if cidl is set to 0. If I
> change the if line to "if (!cidl && !apidl)" (so E_INVALIDARG is
> returned to office), saving the file works. Should this
Hello,
I'm doing a few test with Microsoft Office 2003, and one of the problems I
notice is that any app(word, excel, powerpoint, access tested) refuses to
save new files. Whenever I try to save a file Office tells me that the folder
is write-protected. Opening an existing file and saving it aga
17 matches
Mail list logo
