> Where are the patches? Should they have been attached here?
Sorry, I guess I should have specified. The patches are in the bugzilla
entry http://bugs.winehq.org/show_bug.cgi?id=10495 . The patches are too
big for attaching.
--
Arthur Taylor <[EMAIL PROTECTED]>
Hello. I have updated the testing pulseaudio waveout patch for
http://bugs.winehq.org/show_bug.cgi?id=10495 The patch has been split in
two. The first adds a stub driver that just creates waveout devices
based upon pulseaudio sinks and adds checks for pulseaudio to
configure.ac. The second patch ad
Umm, disregard all of this... sorry for spam
> To wine developers: would it be useful to review dlls/winmm? Currently
> all mm-drivers (aux, mid, mod, wid, wod) functions are called using
> MDRV_Message calls. The arguments of a MDRV_Message are the device id
> (an array index), the message identif
> Humm, I can see splitting the changes to configure.ac and Makefile.in,
> but as for splitting the rest of it, should I split it per-file?
No. Patches should be split along functional lines. E.g.,
patch 1: add stub driver
patch 2: add small feature x to driver
patch 3: add small feature y to dr
> Hi Art,
>
> > Currently I am looking for any feedback at all.
>
> I believe you've already gotten some: split up your patches so that
> we can read them a little more easily. If you send a large patch as a
> new contributor, it's very unlikely to get committed.
Humm, I can see splitting the
Hi Art,
> Currently I am looking for any feedback at all.
I believe you've already gotten some: split up your patches so that
we can read them a little more easily. If you send a large patch as a
new contributor, it's very unlikely to get committed.
Also, this function:
+/*
+const char * PULSE
I have put a newer patch in bugzilla:
http://bugs.winehq.org/attachment.cgi?id=16412&action=edit
Currently I am looking for any feedback at all. Should I send a message
to wine-patches as well?
> 2. We ought to be able to use PulseAudio's ALSA emulation. If that
> doesn't work, then either our A
Reece Dunn wrote:
> 2008/9/29 Scott Ritchie <[EMAIL PROTECTED]>:
>> Arthur Taylor wrote:
>>> Also, in the patch, configure checks for pulseaudio >= 0.9.7. I have
>>> since noticed that it uses parts of the api from 0.9.11 and compilation
>>> will fail against previous versions.
>>>
>>> Thanks
>> As
2008/9/29 Scott Ritchie <[EMAIL PROTECTED]>:
> Arthur Taylor wrote:
>> Also, in the patch, configure checks for pulseaudio >= 0.9.7. I have
>> since noticed that it uses parts of the api from 0.9.11 and compilation
>> will fail against previous versions.
>>
>> Thanks
>
> As an aside, 0.9.11 is newe
Arthur Taylor wrote:
> Also, in the patch, configure checks for pulseaudio >= 0.9.7. I have
> since noticed that it uses parts of the api from 0.9.11 and compilation
> will fail against previous versions.
>
> Thanks
As an aside, 0.9.11 is newer than most users have (Ubuntu 8.04 has
0.9.10, for in
Hi Arthur,
2008/9/27, Arthur Taylor <[EMAIL PROTECTED]>:
> "If someone wants to write a pulseaudio driver, he should feel free to
> do so, but he should be aware that just writing a simple 20 line
> linear PCM out driver is not sufficient."
> http://bugs.winehq.org/show_bug.cgi?id=10495
>
> I have
>> Great. In general, emailing the patch here will get more feedback
>> than posting it to bugzilla.
>
> Woots!
Um.. I still don't see the patch? Sorry, but I'm too lazy to get it
myself. Could you send it here?
Also, just to warn you: some people disagree that a PulseAudio driver
is a good i
On Sat, 2008-09-27 at 11:37 -0700, Juan Lang wrote:
> Hi Arthur,
>
> > I have written a waveout/in driver for wine to use pulseaudio which is
> > in bugzilla. I would appreciate feedback on it, as I have received
> > little thus far.
>
> Great. In general, emailing the patch here will get more f
Hi Arthur,
> I have written a waveout/in driver for wine to use pulseaudio which is
> in bugzilla. I would appreciate feedback on it, as I have received
> little thus far.
Great. In general, emailing the patch here will get more feedback
than posting it to bugzilla.
> I would appreciate it also
"If someone wants to write a pulseaudio driver, he should feel free to
do so, but he should be aware that just writing a simple 20 line
linear PCM out driver is not sufficient."
http://bugs.winehq.org/show_bug.cgi?id=10495
I have written a waveout/in driver for wine to use pulseaudio which is
in b
15 matches
Mail list logo
