Re: What's wrong with my patch?

2009-08-31 Thread Juan Lang
> I saw that AJ committed patches sent before and after my email, so I > assumed he goes through them in order. It also depends on whether your patch is obviously correct, and your "Julliard rank." Since you're new around here, it's likely your patch will be subject to more scrutiny. Plus Andrew

Re: What's wrong with my patch?

2009-08-31 Thread Jan de Mooij
On Mon, Aug 31, 2009 at 6:25 PM, Juan Lang wrote: > Well, you haven't waited nearly long enough.  Sending it in today and > expecting it to be committed the same day is a bit much. I saw that AJ committed patches sent before and after my email, so I assumed he goes through them in order. Sorry ab

Re: What's wrong with my patch?

2009-08-31 Thread Andrew Eikum
Jan de Mooij wrote: Hello. Subject says it all. I suppose the tests I added may fail on other locales, but there is no other way to test my patch? Should i send it without the tests? Thanks in advance. Jan I can't speak much to the patch itself, but the patch file you attached has an invali

Re: What's wrong with my patch?

2009-08-31 Thread Juan Lang
Hi Jan, > Subject says it all. Well, you haven't waited nearly long enough. Sending it in today and expecting it to be committed the same day is a bit much. --Juan

What's wrong with my patch?

2009-08-31 Thread Jan de Mooij
Hello. Subject says it all. I suppose the tests I added may fail on other locales, but there is no other way to test my patch? Should i send it without the tests? Thanks in advance. Jan -- Forwarded message -- From: Jan de Mooij Date: Mon, Aug 31, 2009 at 2:24 PM Subject: comc

What's wrong with ...

2007-10-29 Thread Christian Eggers
Hello, I've submitted a patch to wine-patches 5 days ago which has not been added yet: "Added wrapper dll for ct-api(CardTerminal API)" http://www.winehq.org/pipermail/wine-patches/2007-October/045716.html I think that most of the code has already been reviewed: The 1st version has already bee

any clues as to what's wrong with patches (system palette entries)?

2007-10-24 Thread Alexander Dorofeyev
Hello. I've sent a patch that changes X11DRV_GetSystemPaletteEntries behavior and a test something like a week ago. I guess they fell into that so called not obviously correct category (or maybe not correct at all one). I'll appreciate any comments or suggestions on possible improvements. Than