re: WM_GETICON patch

2006-06-12 Thread Dan Kegel
Mike Hearn wrote: ... obviously WM_GETICON requires inter-process bitmaps to be supported in some fashion, which is a fair bit of work. Maybe for efficiency reasons even requiring the dreaded remote thread creation/service thread :) Adding support for remote thread creation is on Tommy Kho's to

Re: WM_GETICON patch

2006-06-12 Thread Chris
On Monday 12 June 2006 06:42, Mike Hearn wrote: > Actually images are stored as pixmaps in the X server, so it'd be awfully > convenient if we could leverage that but I suspect the need to support > non-X display systems means we have to do it the hard way, by shovelling > image bits across the soc

Re: WM_GETICON patch

2006-06-12 Thread Mike Hearn
On Sun, 11 Jun 2006 20:26:11 -0700, Chris wrote: > Aren't icons already created on the global heap? They're created with > GlobalAlloc16, and (optionally) added to a link list of shared icons. No, this is a confusing Win32ism. The "global heap" is not actually global, it's process-local. There *

Re: WM_GETICON patch

2006-06-11 Thread Chris
On Sunday 11 June 2006 13:42, Mike Hearn wrote: > Well I guess this is a slight improvement but obviously WM_GETICON > requires inter-process bitmaps to be supported in some fashion, which is a > fair bit of work. Aren't icons already created on the global heap? They're created with GlobalAlloc16

Re: WM_GETICON patch

2006-06-11 Thread Mike Hearn
On Sat, 10 Jun 2006 16:35:45 -0700, Chris wrote: > Originally GeoShell would show no icon on the taskbar and print > a lot of fixme messages about it being unsupported. With this patch it now > (always) shows the Wine glass icon for programs, with no such fixme messages. Well I guess this is a

Re: WM_GETICON patch

2006-06-10 Thread Chris
I updated the patch a little more to handle WM_QUERYDRAGICON as well (something else that was complained about with GeoShell), since it's dealt with similarly to WM_GETICON (lparam is unused and an HICON is returned in the result). An odd effect now is that apps are showing one of GeoShell's ar

WM_GETICON patch

2006-06-10 Thread Chris
Here's a patch I'm trying to make to implement the WM_GETICON message, which programs like GeoShell (a Win32 taskbar replacement) would use to get a taskbar icon for the running processes. I'm not quite sure if it's proper or not, though. Originally GeoShell would show no icon on the taskbar and