Re: WLDAP32: tests for ldap_err2string{A,W} and LdapMapErrorToWin32 (#2)

2005-08-02 Thread Hans Leidekker
On Tuesday 2 August 2005 16:30, Alexandre Julliard wrote: > I don't see any point in testing the actual strings. Surely no code is > going to rely on the exact string contents. OK, fair enough. I had written it to get at the strings, but I agree it has limited value in detecting regressions. -H

Re: WLDAP32: tests for ldap_err2string{A,W} and LdapMapErrorToWin32 (#2)

2005-08-02 Thread Alexandre Julliard
Hans Leidekker <[EMAIL PROTECTED]> writes: > This patch restricts the ldap_err2string tests to a specific thread locale. > > -Hans > > Changelog > Tests for ldap_err2string{A,W} and LdapMapErrorToWin32. I don't see any point in testing the actual strings. Surely no code is going to rely on the

Re: WLDAP32: tests for ldap_err2string{A,W} and LdapMapErrorToWin32

2005-08-02 Thread Hans Leidekker
On Tuesday 2 August 2005 06:52, Dmitry Timoshkov wrote: > > +static const char* WLDAP32_error[] = { > > +"Success", > > This test won't work on a not english locale once somebody adds > translations for another language. You either need to prevent > the test from running on locales different

Re: WLDAP32: tests for ldap_err2string{A,W} and LdapMapErrorToWin32

2005-08-01 Thread Dmitry Timoshkov
"Hans Leidekker" <[EMAIL PROTECTED]> wrote: > +static const char* WLDAP32_error[] = { > +"Success", This test won't work on a not english locale once somebody adds translations for another language. You either need to prevent the test from running on locales different from english, or find an