Re: WINED3D: Fix a possible null dereference (try 2)

2008-04-19 Thread Stefan Dösinger
Am Samstag, 19. April 2008 19:06:07 schrieb H. Verbeet: > Try not to change the encoding of the file. > I'm not sure if we ever considered simply using UTF-8 for source > files, but it would probably prevent some issues like this. I could change my name :-) There was some consideration of UTF 8, b

Re: WINED3D: Fix a possible null dereference (try 2)

2008-04-19 Thread H. Verbeet
On 19/04/2008, David Adam <[EMAIL PROTECTED]> wrote: > This time, with tests for d3d8 and d3d9. > > David Adam > Looks mostly ok, but you do need a \n at the end of these ok messages: > +ok(hr == D3DERR_INVALIDCALL, "Expected D3DERR_INVALIDCALL, got %s", > DXGetErrorString8(hr)); > +ok(h

Re: WINED3D: Fix a possible null dereference.

2008-04-19 Thread H. Verbeet
On 19/04/2008, David Adam <[EMAIL PROTECTED]> wrote: > The Sting Demo calls the function > IDirect3DDeviceImpl_7_SetMaterial (in ddraw/device.c) with > Mat=NULL. > Then, this makes the function IWineD3DDeviceImpl_SetMaterial (in > wined3d/device.c) crashes in the line > This->updateStateBlock->mate