Re: VarRound implementation

2004-02-23 Thread Rolf Kalbermatter
Fabian Cenedese <[EMAIL PROTECTED]> wrote: >>be. You have 2 choices: try and match their exact algorithm (v. hard >>w/o reverse engineering) or use the dutch rounding method (this makes >>more sense IMO). > >I couldn't find anything about "Dutch rounding". Isn't rounding exactly >defined? 0.1-0.4

Re: VarRound implementation

2004-02-23 Thread Fabian Cenedese
>be. You have 2 choices: try and match their exact algorithm (v. hard >w/o reverse engineering) or use the dutch rounding method (this makes >more sense IMO). I couldn't find anything about "Dutch rounding". Isn't rounding exactly defined? 0.1-0.4 round down -> 0.0, 0.5-0.9 round up -> 1.0? >> A

Re: VarRound implementation

2004-02-20 Thread Jon Griffiths
Hi, >VT_R4: 7.850 -> VarRound(1) -> 7.800 >VT_R4: 7.851 -> VarRound(1) -> 7.900 >Is this the binary representation (in)accuracy? MS state that rounding is dependent on the internal binary representation of the number and thus VarRound doesn't always get it right, i.e. you can't tell with any cert

Re: VarRound implementation

2004-02-20 Thread Dmitry Timoshkov
"Fabian Cenedese" <[EMAIL PROTECTED]> wrote: > For this I tested more cases on Windows and got strange results (in my view). > > VT_R4: 7.850 -> VarRound(1) -> 7.800 > VT_R4: 7.851 -> VarRound(1) -> 7.900 > > Is this the binary representation (in)accuracy? > How can I test if the rounding worked

Re: VarRound implementation

2004-02-20 Thread Fabian Cenedese
>Without a test how can you know if this implementation produces the correct values? >What about variant type conversions? It seems silly to send a patch without testing >it... Now I'm confused. I'm adding more types to VarRound and I'm also implementing the test_VarRound function (programmer

Re: VarRound implementation

2004-02-19 Thread Fabian Cenedese
>Without a test how can you know if this implementation produces the correct values? >What about variant type conversions? It seems silly to send a patch without testing >it... I just saw that I submitted a patch with some debug code in it. I guess I'll have to send it again anyway :) bye F

Re: VarRound implementation

2004-02-19 Thread Fabian Cenedese
>Without a test how can you know if this implementation produces the correct values? >What about variant type conversions? It seems silly to send a patch without testing >it... I didn't mean that I never tested it. Of course I had a test program with which I found out what results Windows wou

Re: VarRound implementation

2004-02-19 Thread chmorgan
: [EMAIL PROTECTED] > Subject: VarRound implementation > > Hi > > This is the implementation of the Variant Round function. I tried to also create a > test > function. But I didn't manage to. > > > > Changelog: > Fabian Cenedese <[EMAIL PROTECTE