André Hentschel writes:
> @@ -84,18 +84,14 @@ static void test_IsThemed(void)
> SetLastError(0xdeadbeef);
> bThemeActive = pIsThemeActive();
> trace("Theming is %s\n", (bThemeActive) ? "active" : "inactive");
> +ok( GetLastError() == ERROR_SUCCESS ||
> +broken(GetLastEr
Robert Grocott wrote:
> --- a/dlls/user32/button.c
> +++ b/dlls/user32/button.c
> @@ -190,12 +190,7 @@ static inline UINT get_button_type( LONG window_style )
> /* paint a button of any type */
> static inline void paint_button( HWND hwnd, LONG style, UINT action )
> {
> -if (btnPaintFunc[
On 3/4/2012 16:04, Robert Grocott wrote:
(Tried sending this a couple of times previously, but apparently
emails are silently ignored if you're not subscribed to the mailing
list? If this ends up being a duplicate message, sorry about that.)
The attached patch fixes an unreported bug: themed b
Alistair Leslie-Hughes writes:
> Hi,
>
>
> Changelog:
> uxtheme: Return error on invalid parameters
Get/SetPropW already check the handle, don't add redundant checks.
--
Alexandre Julliard
julli...@winehq.org
André Hentschel wrote:
> Applied Dmitry's suggestions
> -HTHEME WINAPI OpenThemeData(HWND hwnd, LPCWSTR pszClassList)
> +HTHEME WINAPI OpenThemeDataEx(HWND hwnd, LPCWSTR classlist, DWORD flags)
> {
> -WCHAR szAppBuff[256];
> -WCHAR szClassBuff[256];
> -LPCWSTR pszAppName;
> -LPC
André Hentschel wrote:
> -TRACE("(%p,%s)\n", hwnd, debugstr_w(pszClassList));
> +TRACE("(%p,%s, %u)\n", hwnd, debugstr_w(pszClassList), Flags);
> +
> +if(Flags)
> +FIXME("unhandled Flags: %u\n", Flags);
...
> +#define OTD_FORCE_RECT_SIZING 0x0001
> +#define OTD_NONCLIEN
On Tue, Dec 9, 2008 at 2:35 AM, Michael Karcher
<[EMAIL PROTECTED]> wrote:
> Am Dienstag, den 09.12.2008, 00:39 -0600 schrieb Austin English:
>> -MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &g);
>> -if(MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &b)) {
>> +if(MSSTY
Am Dienstag, den 09.12.2008, 00:39 -0600 schrieb Austin English:
> -MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &g);
> -if(MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &b)) {
> +if(MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &r) &&
> +MSSTYLES_GetNext
2008/10/28 James Hawkins <[EMAIL PROTECTED]>:
> On Tue, Oct 28, 2008 at 10:17 AM, Rob Shearman <[EMAIL PROTECTED]> wrote:
>> 2008/10/28 James Hawkins <[EMAIL PROTECTED]>:
>>> This code is screaming for a goto.
>>
>> I disagree.
>
> Yes, it was late and my mind stopped after the next thought. There
On Tue, Oct 28, 2008 at 10:17 AM, Rob Shearman <[EMAIL PROTECTED]> wrote:
> 2008/10/28 James Hawkins <[EMAIL PROTECTED]>:
>> +HRESULT hr = S_OK;
>> TRACE("(%p,%s,%s)\n", hwnd, debugstr_w(pszSubAppName),
>> debugstr_w(pszSubIdList));
>> -hr = UXTHEME_SetWindowProperty(hwnd, atS
2008/10/28 James Hawkins <[EMAIL PROTECTED]>:
> +HRESULT hr = S_OK;
> TRACE("(%p,%s,%s)\n", hwnd, debugstr_w(pszSubAppName),
> debugstr_w(pszSubIdList));
> -hr = UXTHEME_SetWindowProperty(hwnd, atSubAppName, pszSubAppName);
> +if(!IsWindow(hwnd))
> +hr = E_HANDLE;
"Reece Dunn" <[EMAIL PROTECTED]> writes:
> @@ -691,11 +691,21 @@ HRESULT WINAPI SetWindowTheme(HWND hwnd, LPCWSTR
> pszSubAppName,
> HRESULT hr;
> TRACE("(%p,%s,%s)\n", hwnd, debugstr_w(pszSubAppName),
>debugstr_w(pszSubIdList));
> +
> +if(!IsWindow(hwnd))
> +{
> +
On Tue, Oct 28, 2008 at 2:29 AM, Reece Dunn <[EMAIL PROTECTED]> wrote:
> Hi,
>
> This fixes the todo blocks in the SetWindowTheme tests.
>
> Changes:
> v2 -- initialise the hr variable so that it is initialised in the
> case where hwnd is a valid window handle.
>
Please fix your changelog entry t
he source HDC, and CreateCompatibleBitmap in the same way. If these
> operations preserve the alpha channel, and BitBlt(SRCCOPY) does too, the
> patch as a whole should be correct.
No, BitBlt and friends won't preserve the alpha channel. But that should
be fixed in gdi, not worked arou
On 23.04.2008 01:00, Alex Villacís Lasso wrote:
> Have you seen a theme that uses alpha and breaks with my patch?
It's more of a dim recollection from the time I worked on the theming
stuff. Mind you, it's a while back now, so assuming I remember right the
underlying issue might have been fixe
Frank Richter escribio':
> On 22.04.2008 13:47, Alexandre Julliard wrote:
>
>> uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an
>> appropriately-sized memory bitmap out of the tile instead of iterating with
>> UXTHEME_Blt() directly.
>>
On 22.04.2008 13:47, Alexandre Julliard wrote:
> uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an
> appropriately-sized memory bitmap out of the tile instead of iterating with
> UXTHEME_Blt() directly.
But does that keep the alpha channel intact?
-f.r.
"Reece Dunn" <[EMAIL PROTECTED]> writes:
> The Vista return code is what wine is returning, so remove the todo
> block as well.
Not for me:
../../../tools/runtest -q -P wine -M uxtheme.dll -T ../../.. -p
uxtheme_test.exe.so system.c && touch system.ok
system.c:420: Test failed: Expected E_POINT
Paul Vriens <[EMAIL PROTECTED]> writes:
> On Fri, 2006-06-16 at 15:25 +0200, Alexandre Julliard wrote:
>> This won't work right if theming is disabled, since IsAppThemed
>> returns FALSE in that case. Also note that GetLastError doesn't return
>> an HRESULT, so ERROR_SUCCESS is a better name than
On Fri, 2006-06-16 at 15:25 +0200, Alexandre Julliard wrote:
> Paul Vriens <[EMAIL PROTECTED]> writes:
>
> > +SetLastError(0xdeadbeef);
> > +bAppThemed = pIsAppThemed();
> > +todo_wine
> > +{
> > +ok( bAppThemed == FALSE, "Expected FALSE as this test executable
> > is not
Paul Vriens <[EMAIL PROTECTED]> writes:
> +SetLastError(0xdeadbeef);
> +bAppThemed = pIsAppThemed();
> +todo_wine
> +{
> +ok( bAppThemed == FALSE, "Expected FALSE as this test executable is
> not (yet) themed.\n");
> +ok( GetLastError() == S_OK,
> +"Exp
"Paul Vriens" <[EMAIL PROTECTED]> writes:
> I've sent 2 emails that are (for now) silently ignored:
>
> http://www.winehq.org/pipermail/wine-patches/2006-June/027253.html
> http://www.winehq.org/pipermail/wine-patches/2006-June/027350.html
>
> They both have
Hi,
I've sent 2 emails that are (for now) silently ignored:
http://www.winehq.org/pipermail/wine-patches/2006-June/027253.html
http://www.winehq.org/pipermail/wine-patches/2006-June/027350.html
They both have to do with uxtheme and were meant as a starter for
conformance tests and of cours
On Wed, 2006-06-07 at 08:44 +0200, Paul Vriens wrote:
> Hi,
>
> I've added the framework and some initial (simple) tests. No
> functionality tests (yet), only parameter and return-value checking.
>
> This one also 'fixes' the tests for Wine when theming is enabled.
>
> Changelog
> Added framew
Am Montag, 5. Dezember 2005 11:48 schrieb Alexandre Julliard:
> Stefan Leichter <[EMAIL PROTECTED]> writes:
> > As i understand you, the ordinals of uxtheme dll displayed in the relay
> > trace are wrong. Different function calls (according to the number of
> > argu
Stefan Leichter <[EMAIL PROTECTED]> writes:
> As i understand you, the ordinals of uxtheme dll displayed in the relay trace
> are wrong. Different function calls (according to the number of arguments) in
> the relay log are displayed as function with the ordianl 1.
Most like
Am Samstag, 3. Dezember 2005 18:59 schrieb Marcus Meissner:
> On Sat, Dec 03, 2005 at 06:16:48PM +0100, Stefan Leichter wrote:
> > Hi,
> >
> > i am a little confuse about the uxtheme dll. I have a program that raises
> > an execption after each call (not the retur
On Sat, Dec 03, 2005 at 06:16:48PM +0100, Stefan Leichter wrote:
> Hi,
>
> i am a little confuse about the uxtheme dll. I have a program that raises an
> execption after each call (not the return!) to the ordinal 1 of the dll. The
> strange thing is the relay log shows up to eigh
Hi,
i am a little confuse about the uxtheme dll. I have a program that raises an
execption after each call (not the return!) to the ordinal 1 of the dll. The
strange thing is the relay log shows up to eight arguments for the function
call, but according to the spec file of the uxtheme dll the
order to get
theming, but we are using version 5.0 implementation.
The above article also mentions how to use commctl version 5 with
uxtheme, but we need some concrete theming/non theming examples
inorder to fix the notiious WMGETTEXT bug that came with
unicodification of controls.
I will be
Francois Gouget <[EMAIL PROTECTED]> writes:
> Before a 64bit integer was declared as 'long long'. This means both of
> these prototypes would be considered to match reset_int64(long long):
>
> WINAPI void reset_int64(INT v1, INT v2);
> WINAPI void reset_int64(LONGLONG v);
>
> And indeed there wer
On Mon, 12 Sep 2005, Alexandre Julliard wrote:
Francois Gouget <[EMAIL PROTECTED]> writes:
That's from memory so it should be checked, but I believe winapi_check
had a hack to check consistency between the spec file and the function
prototypes in the C files. This patch likely breaks that hack
Francois Gouget <[EMAIL PROTECTED]> writes:
> That's from memory so it should be checked, but I believe winapi_check
> had a hack to check consistency between the spec file and the function
> prototypes in the C files. This patch likely breaks that hack, but more
> importantly winapi_check is g
On Mon, 12 Sep 2005, Alexandre Julliard wrote:
Robert Shearman <[EMAIL PROTECTED]> writes:
Wouldn't it be better to extend the spec format to allow for a longlong
type instead?
I was wondering about that too.
I considered doing that, but I decided it would just add complexity
for no real
Robert Shearman <[EMAIL PROTECTED]> writes:
> Wouldn't it be better to extend the spec format to allow for a longlong
> type instead?
I considered doing that, but I decided it would just add complexity
for no real reason. If we really need more detailed parameter info
then we need to retrieve t
Alexandre Julliard wrote:
Log message:
Specify 64-bit integers as double instead of long long in spec files
so that we get the correct number of arguments.
Wouldn't it be better to extend the spec format to allow for a longlong
type instead?
--
Rob Shearman
Great thanks, missed that patch.
-aric
Frank Richter wrote:
On 01.09.2005 15:59, Aric Stewart wrote:
Any chance these changes could be made?
Actually, some chaps in #winehackers asked for the same already ;) :
http://www.winehq.org/pipermail/wine-patches/2005-August/020373.html
-f.
On 01.09.2005 15:59, Aric Stewart wrote:
> Any chance these changes could be made?
Actually, some chaps in #winehackers asked for the same already ;) :
http://www.winehq.org/pipermail/wine-patches/2005-August/020373.html
-f.r.
Thanks for the great work on this! It is really cool, however I am
having a dependency problem that would be great to resolve.
uxtheme currently links in shlwapi.dll, shlwapi.dll in turn links in
ole32.dll. Since WM_NCCREATE seems to load uxtheme it would be that
ole32 is being loaded almost
On 15.07.2005 19:56, Robert Shearman wrote:
> You don't need any code for this. Just add uxtheme to DELAYIMPORTS in
> the Makefile.in and it will be done automagically for you.
Duh :P
I'll include that change when I send some patch with actual
uxtheme-using code then.
-f.r.
Frank Richter wrote:
Frank Richter <[EMAIL PROTECTED]>
Added a wrapper to delay-load uxtheme.dll, as needed by future theming
changes.
Hey Frank,
You don't need any code for this. Just add uxtheme to DELAYIMPORTS in
the Makefile.in and it will be done automagically for yo
Frank Richter <[EMAIL PROTECTED]> writes:
> +static BOOL CALLBACK UXTHEME_broadcast_msg (HWND hWnd, LPARAM msg)
> +{
> +if (hWnd == NULL)
> +{
> + EnumWindows (UXTHEME_broadcast_msg, msg);
> +}
> +else
> +{
> + PostMessageW(hWnd, msg, 0, 0);
> + EnumChildWindows (hW
On 03.07.2005 18:15, Frank Richter wrote:
> Well, technically, according to MSDN for NULL: "The function behaves
...nevermind that the block wouldn't even be called for NULL. Duh.
-f.r.
signature.asc
Description: OpenPGP digital signature
On 03.07.2005 18:15, Frank Richter wrote:
> Well, technically, according to MSDN for NULL: "The function behaves
...nevermind that the block wouldn't even be called for NULL. Duh.
-f.r.
On 03.07.2005 18:01, Dimi Paun wrote:
> This function would be more useful (and usage clearer) if it
> took the msg as an argument (also I think you can get rid of
> UXTHEME_EnumChildProc too, untested):
True.
> Note: the 'if' for PostMessageW was superfluous.
Well, technically, according to MSD
On Sun, 2005-07-03 at 15:11 +0200, Frank Richter wrote:
> +static void UXTHEME_broadcast_themechange (HWND hWnd)
> +{
> +if (hWnd == NULL)
> +{
> + EnumWindows (UXTHEME_EnumChildProc, 0);
> +}
> +else
> +{
> + if (hWnd != NULL) PostMessageW(hWnd, WM_THEMECHANGED, 0,
alogy: drawing of a hand
* eg any 2 word processors will have some structural similarities
> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Mike McCormack
> Sent: 25. marts 2005 10:39
> To: Jonathan Wilson
> Cc: wine-devel@winehq.org; [E
Jonathan Wilson wrote:
What I am doing here is clean-room reverse engineering.
There's no reason that we need to expose ourselves to any legal risk at
all. It may be your opinion that reading assembly code and describing
it is legal and safe, but I don't agree and I'm sure others who work on
W
What I am doing here is clean-room reverse engineering.
Essentially it involves taking existing binary modules and sources of
information and writing up what they do in a way that isnt violating the
copyright on the origonal (IANAL but I dont think what I posted violates
the copyright on the win
Jonathan Wilson wrote:
Exactly how the theme service and theme engine works "under the hood"
doesnt matter.
But for ReactOS and WINE purposes, I suggest we implement the following:
1.A function similar to RegisterUserApiHooks/UnregisterUserApiHooks
(either reverse engineer the MS function or writ
Also related to this (as pointed out in IRC) is Activation Contexts/SxS
stuff), we need this to make sure the correct window classes are used at
the correct time.
find where this bit happens
but I suspect the themes service does this) control passes to ordinal 34 in
uxtheme.dll (aka ThemeHooksInstall acording to uxtheme.pdb). This function
calls an undocumented function in user32 called RegisterUserApiHooks (which
appears to be taylor made for uxtheme to
UXTheme I think is reasonably complete, however our widget toolkit doesn't
use it at all so Wine itself is not themable.
thanks -mike
On Tue, 06 Jul 2004 20:07:47 +0200, Olaf Leidinger wrote:
> Hello!
>
> I'm new to the list and I'd like to know how complete the Windo
Hello!
I'm new to the list and I'd like to know how complete the Windows-XP
theme support is.
I don't know anything about XP themes or win32-api programming in
general but I wondered if it would be possible to create a "metatheme -
plugin" for wine.
Metatheme [1] is a new project which aim is t
On Monday 16 February 2004 04:26 am, Mike Hearn wrote:
> Presumably this is only if you have a native luna theme lying around
> somewhere, right? Do you know what files we need?
Luna would work yes, but thats not the only theme out there
Many skinning sites have sections for msstyle themes, you co
On Mon, 16 Feb 2004 00:40:49 -0500, Kevin Koltzau wrote:
> With this some apps may start looking partly themed (eg. the toolbar buttons
> in newer versions of mIRC are themed), and we can start adding theming code
> to widgets
Presumably this is only if you have a native luna theme lying around
On Wed, 28 Jan 2004 21:14:39 +0200, MediaHost (TM) wrote:
> I see this also bothering Winamp 5would maybe run too.
To get WinAmp 5 running use the "Classic" theme instead of Modern.
Modern uses stuff we haven't implemented yet.
Win98 doesn't have themes, so you've got nothing to worry about as far as registry
settings go.
Only WinXP and Win2003 (and anything newer then those) have theming support
On Wednesday 28 January 2004 02:14 pm, MediaHost \(TM\) wrote:
> OK, good to know! Anyway, I made a import of a registry file
t; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
Sent: Wednesday, January 28, 2004 9:00 PM
Subject: Re: UXTHEME
> There have been a couple patches recently commited to CVS related to that,
this one in particular may help
> http://cvs.winehq.org/patch.py?id=10856
> Although I'm
aHost \(TM\) wrote:
> Hi,
>
> I wanted to know about the issue with uxtheme and the newest release:
>
> As stated at
> http://www.winehq.com/?issue=206#Broken%20Apps:%20IE%20Setup%20and%20Lotus%
>20Notes? explorer only bombs, when a theme installed and selected in your
>
Hi,
I wanted to know about the issue with uxtheme and
the newest release:
As stated at http://www.winehq.com/?issue=206#Broken%20Apps:%20IE%20Setup%20and%20Lotus%20Notes?
explorer only bombs, when a theme installed
and selected in your registry . How do I go about uninstalling a
>
> This follows the same lines, in some cases
> MSSTYLES_SetActiveTheme would return success when in fact it failed
> Apply on top of Vitaliy's patch
>
> Changelog:
> Ensure MSSTYLES_SetActiveTheme fails when theme fails to load
...
> invalid_theme:
> if(hTheme) FreeLibrary(hTheme);
On Wed, 2004-01-21 at 06:57, jds wrote:
> 0x40fc2453 (UXTHEME.DLL.GetThemeSysString+0x4e3 in UXTHEME.DLL): incl 0x0(%esi)
> Wine-dbg>quit
A large UXTHEME update was committed in the last few days. It appears
this causes the IE installer to crash. I'm currently bogged down with
e
Kevin Koltzau <[EMAIL PROTECTED]> writes:
> I guess I'd probably need to define each string beforehand like
> WCHAR szString[] = {'S','T','R','I','N','G','\0'};
> and use that in the map, but before I undergo that large task I would like to verify
> thats the best way
Either that, or you can dec
On Monday 12 January 2004 07:07 pm, Alexandre Julliard wrote:
> Kevin Koltzau <[EMAIL PROTECTED]> writes:
> > As far as inefficent that wasnt my concern as the data is only
> > loaded once at startup and never touched again
> > If it is an issue I will change this and resubmit
>
> Startup performan
Kevin Koltzau <[EMAIL PROTECTED]> writes:
> As far as inefficent that wasnt my concern as the data is only
> loaded once at startup and never touched again
> If it is an issue I will change this and resubmit
Startup performance is definitely an issue. This is done for every
app, and we are alread
The reason I did that was because of the large quantity of data, it was easier to
define unicode strings in resources
then it is to do in code, and I got a free method of seperating part/state data for
each class
As far as inefficent that wasnt my concern as the data is only loaded once at startu
Kevin Koltzau <[EMAIL PROTECTED]> writes:
> This is a ton of infrastructure for my future patches, and a full
> implementation of GetThemeDocumentationProperty which I primarilly
> used to test my INI file processing, and its now possible to set the
> current theme through the API..not that its mu
Kevin Koltzau <[EMAIL PROTECTED]> writes:
> Or would it be preferable that I stick with the way windows does it
> (by duplicating the ini file loading within uxtheme) and do all the
> processing in memory?
Yes that would be much better. Parsing a .ini file is not hard, and
ws does it (by duplicating
the ini file loading within uxtheme)
and do all the processing in memory?
Index: dlls/kernel/profile.c
===
RCS file: /home/wine/wine/dlls/kernel/profile.c,v
retrieving revision 1.4
diff -u -r1.4 profile.c
--- d
If I remember currectly in noticed it in the 5.12.2003
cvs, I am not sure what version before it was ok but I
assumed it was the
http://www.winehq.org/hypermail/wine-cvs/2003/12/0062.html
patch that said "Added stubs for all functions." to
the uxtheme
it sounded related
now I a
I'm having the same problem. Not quite sure what is causing it, but its definatly not
uxtheme
you can see for yourself by setting
"uxtheme" = ""
in your DllOverrides, problem doesn't go away
On Sunday 14 December 2003 02:58 pm, hatky wrote:
> I know these are stu
I know these are stubs but since they were added more
of the splash screen and the top of the main
application of Trillian has been cut off
freeware at:
http://download.com.com/3000-2150-10047473.html?part=trillian&subj=dlpagtag=button
home page at:
http://www.ceruleanstudios.com/downloads/
Hatk
At 17.20 12/11/2003, Steven Edwards wrote:
We have a uxtheme.dll that is being developed in ReactOS cvs also that
supports loading native WinXP themes
ha! I wish. Nope, mine is a complementary effort. It's a fake UxTheme API
that actually draws in the classic Windows style, to make the f
Hello Kevin,
--- Kevin Koltzau <[EMAIL PROTECTED]> wrote:
> It is not possible to get native uxtheme from an XP installation
> working under
> wine.
> However I am currently working on a uxtheme.dll implementation for
> wine that
> will support loading native WinXP the
On Tuesday 11 November 2003 05:26 am, Jonathan Wilson wrote:
> Is such a thing possible or not?
> i.e. getting uxtheme, the existing themes and the common controls dll
> (various versions of it) working on ROS or Wine fesable?
It is not possible to get native uxtheme from an XP ins
Is such a thing possible or not?
i.e. getting uxtheme, the existing themes and the common controls dll
(various versions of it) working on ROS or Wine fesable?
Can you trace the native uxtheme and see how Microsoft did it? They
should know the best way, after all.
On October 15, 2003 08:09 pm, Kevin Koltzau wrote:
> One possible solution would be to call the PROFILE_* functions (which are
> located in kernel/profile.c) directly which seem to work in a way that
> would make this very easy, but overall sounds like a very bad idea...
Well, it is, it breaks DLL
Within an msstyles file the primary specification is basically a unicode INI
file within one of the resources (well, there are a few ini files for
different parts of the theme)
Currently I'm extracting the ini file from resources into a temp file, and
then using GetPrivateProfile* to retrieve v
80 matches
Mail list logo
