Re: USER32: result of ScrollBar functions review (4th try)

2005-01-09 Thread Alexandre Julliard
Vitaly Lipatov <[EMAIL PROTECTED]> writes: > :( How I can send changes as separate patches if I do all fixes > in the same time? Really, I will try do as you tell me when it > is possible. > The patch we talk about has too few chances to be separated... It's pretty easy, just get a fresh copy

Re: USER32: result of ScrollBar functions review (4th try)

2005-01-08 Thread Vitaly Lipatov
On Saturday 08 January 2005 21:44, Alexandre Julliard wrote: > > +if (nBar == SB_CTL) > > + FIXME("needs to send SMB_SETRANGE when SB_CTL\n"); > > +//return SendMessageW(hwnd, SBM_SETRANGE, > > (WPARAM)0, (LPARAM)0); return TRUE; > > There's no reason to add a FIXME, calling SetScrollIn

Re: USER32: result of ScrollBar functions review (4th try)

2005-01-08 Thread Alexandre Julliard
Vitaly Lipatov <[EMAIL PROTECTED]> writes: > @@ -1728,12 +1821,15 @@ > SCROLLINFO info; > > TRACE("hwnd=%p nBar=%d min=%d max=%d, bRedraw=%d\n", hwnd, nBar, minVal, > maxVal, bRedraw); > - > + > info.cbSize = sizeof(info); > info.fMask = SIF_RANGE; > info.nMin = mi

Re: USER32: result of ScrollBar functions review

2005-01-03 Thread Vitaly Lipatov
В сообщении от 3 Январь 2005 18:23 Dmitry Timoshkov написал(a): > > +FIXME("check me"); > > +if (psbi->cbSize != sizeof(RECT)) > > +return FALSE; > > Why are you testing psbi->cbSize for sizeof(RECT) here? It is my mistake. The corrected version placed below: --- dlls/user/1/scro

Re: USER32: result of ScrollBar functions review

2005-01-03 Thread Dmitry Timoshkov
"Vitaly Lipatov" <[EMAIL PROTECTED]> wrote: > +/* New Scrollbar info since Windows 98, Windows NT 4.0 with SP6 */ > +typedef struct tagSCROLLBARINFO > +{ > +DWORD cbSize; /* Size of SCROLLBARINFO struct */ ... > +BOOL WINAPI GetScrollBarInfo(HWND hwnd, LONG idObject, LPSCROLLBARI