re: Trace fix

2007-04-26 Thread Dan Kegel
Alexandre wrote: No, resend just one, making absolutely sure that you got everything right, and wait for it to be committed before sending the next one. You have to make sure you can walk before you try to run. I would also suggest finding somebody to pre-review your patch before you send it to

Re: Trace fix

2007-04-26 Thread Tom Spear
On 4/26/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote: "Tom Spear" <[EMAIL PROTECTED]> writes: > Ok, so then if I resend them now, will you take a look? I believe I > have fixed every problem with each one, as I havent gotten any more > comments about something being borked. No, resend just

Re: Trace fix

2007-04-26 Thread Alexandre Julliard
"Tom Spear" <[EMAIL PROTECTED]> writes: > Ok, so then if I resend them now, will you take a look? I believe I > have fixed every problem with each one, as I havent gotten any more > comments about something being borked. No, resend just one, making absolutely sure that you got everything right,

Re: Trace fix

2007-04-26 Thread Tom Spear
On 4/26/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote: That's particularly true for cosmetic patches like typo fixes; if I have to spend more than 10 seconds on such a patch, chances are it will end up in /dev/null. Ok, so then if I resend them now, will you take a look? I believe I have fi

Re: Trace fix

2007-04-26 Thread Alexandre Julliard
"Tom Spear" <[EMAIL PROTECTED]> writes: > Just curious if Alexandre missed my patches for regedit and my trace > fix for uninstaller, or if there is a backlog of commits to be done, > or if he even plans to commit them, and if not, why.. You have been sending way too man

Trace fix

2007-04-26 Thread Tom Spear
Just curious if Alexandre missed my patches for regedit and my trace fix for uninstaller, or if there is a backlog of commits to be done, or if he even plans to commit them, and if not, why.. http://www.winehq.org/pipermail/wine-patches/2007-April/038566.html - Spelling fixes for regedit http