Re: There is no need to offset the source rectangle in the reversedirection before scrolling

2005-12-15 Thread Rein Klazes
On Wed, 14 Dec 2005 22:42:28 +0800, you wrote: >Well, the committed patch 1) does fix a visual glitch in the app I'm working on >and 2) passes all the current tests. 1) You know that doesn't make it right. I see it causing visual glitches in *three* programs here, girotel, native hh.exe and win

Re: There is no need to offset the source rectangle in the reversedirection before scrolling

2005-12-14 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > Well, the committed patch 1) does fix a visual glitch in the app I'm working > on > and 2) passes all the current tests. The current tests pass with or without your patch, so it doesn't prove anything. What you need is to come up with a test that

Re: There is no need to offset the source rectangle in the reversedirection before scrolling

2005-12-14 Thread Dmitry Timoshkov
"Rein Klazes" <[EMAIL PROTECTED]> wrote: > /* Then clip again to get the source rectangle that will remain in the > * clipping rect */ > rcSrc = rcClip; >-OffsetRect( &rcSrc, -dx, -dy); > IntersectRect( &rcSrc, &rcSrc, &rcClip); In the first place: with this change the Inte