Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-17 Thread James McKenzie
On 1/17/11 1:07 AM, Dmitry Timoshkov wrote: James McKenzie wrote: +ok (16 == sentLogFontA.lfHeight, "Height not set to 12 for System Font. Height is %d\n", sentLogFontA.lfHeight); 12? Fixed in the next test patch. +ok (96 == ry, "DPI for screen does not equal 96

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-17 Thread Dmitry Timoshkov
James McKenzie wrote: > +ok (16 == sentLogFontA.lfHeight, "Height not set to 12 for System Font. > Height is %d\n", sentLogFontA.lfHeight); 12? > +ok (96 == ry, "DPI for screen does not equal 96 it is %d\n", ry); > +ok (-240 == CharFont1ANSI.yHeight /* Wine */|| 195 == > CharFont1

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread James McKenzie
On 1/16/11 9:55 AM, Nikolay Sivov wrote: On 1/16/2011 19:39, James McKenzie wrote: All: I would like comments on this patch. Another question is how screen resolution affects that test. Thank you and Ge for this. Changing the resolution from 96 to 120 definitely affects the test results.

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread James McKenzie
On 1/16/11 11:42 AM, Greg Geldorp wrote: From: James McKenzie I'll have to figure out how to change the resolution on the test bot and or my local copy of WindowsXP SP2 (not upgradable, no Internet connection to that system. I've now changed the resolution to 1024x768 and 120DPI on VM WXPPRODPY

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread James McKenzie
On 1/16/11 10:58 AM, Charles Davis wrote: On 1/16/11 10:53 AM, James McKenzie wrote: On 1/16/11 10:27 AM, Nikolay Sivov wrote: On 1/16/2011 20:17, James McKenzie wrote: +todo_wine { +SendMessageW(hwndRichEdit, EM_SETMARGINS, EC_USEFONTINFO, MAKELONG(EC_USEFONTINFO, EC_USEFONTINFO))

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread James McKenzie
On 1/16/11 10:58 AM, Nikolay Sivov wrote: On 1/16/2011 20:53, James McKenzie wrote: On 1/16/11 10:27 AM, Nikolay Sivov wrote: On 1/16/2011 20:17, James McKenzie wrote: +todo_wine { +SendMessageW(hwndRichEdit, EM_SETMARGINS, EC_USEFONTINFO, MAKELONG(EC_USEFONTINFO, EC_USEFONTINFO))

RE: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread Greg Geldorp
From: James McKenzie > I'll have to figure out how to change the > resolution on the test bot and or my local copy of WindowsXP SP2 (not > upgradable, no Internet connection to that system. I've now changed the resolution to 1024x768 and 120DPI on VM WXPPRODPY16 from their previous values of 800x6

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread Charles Davis
On 1/16/11 10:53 AM, James McKenzie wrote: > On 1/16/11 10:27 AM, Nikolay Sivov wrote: >> On 1/16/2011 20:17, James McKenzie wrote: > +todo_wine { > +SendMessageW(hwndRichEdit, EM_SETMARGINS, EC_USEFONTINFO, > MAKELONG(EC_USEFONTINFO, EC_USEFONTINFO)); > +} Hm.

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread Nikolay Sivov
On 1/16/2011 20:53, James McKenzie wrote: On 1/16/11 10:27 AM, Nikolay Sivov wrote: On 1/16/2011 20:17, James McKenzie wrote: +todo_wine { +SendMessageW(hwndRichEdit, EM_SETMARGINS, EC_USEFONTINFO, MAKELONG(EC_USEFONTINFO, EC_USEFONTINFO)); +} Hm. This is one of the test case

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread James McKenzie
On 1/16/11 10:27 AM, Nikolay Sivov wrote: On 1/16/2011 20:17, James McKenzie wrote: +todo_wine { +SendMessageW(hwndRichEdit, EM_SETMARGINS, EC_USEFONTINFO, MAKELONG(EC_USEFONTINFO, EC_USEFONTINFO)); +} Hm. This is one of the test cases that was recommended and it appears to b

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread James McKenzie
On 1/16/11 10:24 AM, André Hentschel wrote: see http://test.winehq.org/data/ Will do. I don't want to break Windows9x functionality though. + /* Per http://msdn.microsoft.com/en-us/library/bb761649%(VS.85).asp if the lparam is + EC_USEFONTINFO the Left and Right Margins should be set

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread Nikolay Sivov
On 1/16/2011 20:17, James McKenzie wrote: +todo_wine { +SendMessageW(hwndRichEdit, EM_SETMARGINS, EC_USEFONTINFO, MAKELONG(EC_USEFONTINFO, EC_USEFONTINFO)); +} Hm. This is one of the test cases that was recommended and it appears to be the only one that 'works'. There's no t

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread André Hentschel
Am 16.01.2011 18:17, schrieb James McKenzie: > On 1/16/11 9:55 AM, Nikolay Sivov wrote: >> On 1/16/2011 19:39, James McKenzie wrote: >>> All: >>> >>> I would like comments on this patch. >> Ok. OK >> >>> static HWND new_window(LPCTSTR lpClassName, DWORD dwStyle, HWND parent) { >>>HWND hwnd; >

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread James McKenzie
On 1/16/11 9:55 AM, Nikolay Sivov wrote: On 1/16/2011 19:39, James McKenzie wrote: All: I would like comments on this patch. Ok. static HWND new_window(LPCTSTR lpClassName, DWORD dwStyle, HWND parent) { HWND hwnd; - hwnd = CreateWindow(lpClassName, NULL, dwStyle|WS_POPUP|WS_HSCROLL|WS

Re: RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread Nikolay Sivov
On 1/16/2011 19:39, James McKenzie wrote: All: I would like comments on this patch. Ok. static HWND new_window(LPCTSTR lpClassName, DWORD dwStyle, HWND parent) { HWND hwnd; - hwnd = CreateWindow(lpClassName, NULL, dwStyle|WS_POPUP|WS_HSCROLL|WS_VSCROLL +/* hwnd = CreateWindow(lpClassN

RFC: Richedit: Test Patch for EM_SETMARGINS

2011-01-16 Thread James McKenzie
All: I would like comments on this patch. Thank you. James McKenzie >From da43fe92d633dade59e978e516b43ec409117a2a Mon Sep 17 00:00:00 2001 From: James McKenzie Date: Sun, 16 Jan 2011 08:27:03 -0700 Subject: Adds tests for EM_SETMARGINS for ANSI and UNICODE --- dlls/riched20/tests/editor.c

Re: 64bit bit Wine users, please test patch

2010-03-25 Thread André Hentschel
joerg-cyril.hoe...@t-systems.com schrieb: > Hi, > > you guys running Wine64 on 64bit UNIX, please test > the patch attached to bug #22146 > http://bugs.winehq.org/show_bug.cgi?id=22146 > > The patch is available from > http://bugs.winehq.org/attachment.cgi?id=27027 > > Test code that you can use

64bit bit Wine users, please test patch

2010-03-25 Thread Joerg-Cyril.Hoehle
Hi, you guys running Wine64 on 64bit UNIX, please test the patch attached to bug #22146 http://bugs.winehq.org/show_bug.cgi?id=22146 The patch is available from http://bugs.winehq.org/attachment.cgi?id=27027 Test code that you can use for reporting is at: http://bugs.winehq.org/attachment.cgi?id

Re: Test patch

2009-06-22 Thread Gert van den Berg
On Mon, Jun 22, 2009 at 04:01, Austin English wrote: > The 'patch file' listed in the README should be > deleted, since it's no longer provided. > It seem to be sent to wine-releases.

Re: Test patch

2009-06-21 Thread Austin English
On Sat, Jun 20, 2009 at 9:37 PM, Joshua Reisenauer wrote: > I am sending this test patch to see if I used the correct formatting.  I > would like feedback on what the wine dev community likes and doesn't like in > patches.  For example do you prefer .txt or .patch? .txt please,

Re: Test: patch to add adva,ced d3d settings in winecfg

2009-04-09 Thread Austin English
On Thu, Apr 9, 2009 at 5:32 PM, Austin English wrote: > On Thu, Apr 9, 2009 at 4:28 AM, Warren Dumortier wrote: >> Hello everybody... >> >> My patch to add advanced d3d settings in winecfg is almost ready. >> In fact, i only have to figure out how to detect video memory size to >> display it when

Re: Test: patch to add adva,ced d3d settings in winecfg

2009-04-09 Thread Austin English
On Thu, Apr 9, 2009 at 4:28 AM, Warren Dumortier wrote: > Hello everybody... > > My patch to add advanced d3d settings in winecfg is almost ready. > In fact, i only have to figure out how to detect video memory size to > display it when no key is set to force it or to reset. Stefan D told > me to

Re: Test: patch to add adva,ced d3d settings in winecfg

2009-04-09 Thread Warren Dumortier
2009/4/9 Juan Lang : > Hi Warren, > >> Everything works well and i would like some feedback. > > +    if (!strcmp(buf, "enabled")) > +        CheckDlgButton(dialog, IDC_D3D_MULTISAMPLING, BST_CHECKED); > +    else > +        CheckDlgButton(dialog, IDC_D3D_MULTISAMPLING, BST_UNCHECKED); > +        H

Re: Test: patch to add adva,ced d3d settings in winecfg

2009-04-09 Thread Juan Lang
Hi Warren, > Everything works well and i would like some feedback. +if (!strcmp(buf, "enabled")) +CheckDlgButton(dialog, IDC_D3D_MULTISAMPLING, BST_CHECKED); +else +CheckDlgButton(dialog, IDC_D3D_MULTISAMPLING, BST_UNCHECKED); +HeapFree(GetProcessHeap(), 0, buf); T

Test: patch to add adva,ced d3d settings in winecfg

2009-04-09 Thread Warren Dumortier
Hello everybody... My patch to add advanced d3d settings in winecfg is almost ready. In fact, i only have to figure out how to detect video memory size to display it when no key is set to force it or to reset. Stefan D told me to use DirectDraw, but i wouldn't find. So that is the last thing (exc

Re: ITSS Conformance Test Patch

2005-05-24 Thread Robert Shearman
Dimi Paun wrote: From: "Chris Watmore" <[EMAIL PROTECTED]> This patch adds tests for the itss dll. Please no Perl or Shell scripts -- they will not run on Windows, where we ship tests via winetest. Just code them in C, it shouldn't be too hard. The scripts Chris submitted are use

Re: ITSS Conformance Test Patch

2005-05-24 Thread Dimi Paun
From: "Chris Watmore" <[EMAIL PROTECTED]> > This patch adds tests for the itss dll. Please no Perl or Shell scripts -- they will not run on Windows, where we ship tests via winetest. Just code them in C, it shouldn't be too hard. -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.

Re: Segfault. Conformance Test/Patch in Cabinet.dll

2005-03-10 Thread Vincent =?ISO-8859-1?Q?B=E9ron?=
Le jeu 10/03/2005 à 20:04, Rizwan Kassim a écrit : > A follow up to the cabinet patch we released before hand. It works > perfectly in windows/cl. > > When its in the wine tree, gcc doesn't like it as much. > cabinet_fdi.c: In function `TestCreate': > cabinet_fdi.c:263: warning: passing arg 3 of

Re: Wine cabinet.dll FDI Conformance Test Patch

2005-03-03 Thread Michael Stefaniuc
Dimitrie O. Paun wrote: On Wed, Mar 02, 2005 at 03:41:21PM -0800, Rizwan Kassim wrote: +FNFREE(final_free) { +trace(" FNFREE just called with %d\n",pv); +free(pv); +return; +} +#endif No need for this either. It's a test after all, there's no big deal if you have a memory leak... :) I

Re: gcov and Wine (was: Re: Wine cabinet.dll FDI Conformace Test Patch)

2005-03-02 Thread Alexandre Julliard
Dan Kegel <[EMAIL PROTECTED]> writes: > You could provide a dummy implementation of __bb_init_func > in the preloader, but that's uglier IMHO than just not > passing those options when compiling the preloader. Sure, but you have to do that in a way that doesn't depend on configure, and doesn't re

re: gcov and Wine (was: Re: Wine cabinet.dll FDI Conformace Test Patch)

2005-03-01 Thread Dan Kegel
Mike Hearn wrote: By the way, I talked to Alexandre about the GCOV stuff, basically he wants us to find out why arc profiling borks the preloader. Then the idea is it can be enabled just using CFLAGS. (You're confusing the UCLA guys with the Harvey Mudd guys, Mike!) Here's what [EMAIL PROTECTED] wr

Re: Wine cabinet.dll FDI Conformace Test Patch

2005-03-01 Thread Mike Hearn
By the way, I talked to Alexandre about the GCOV stuff, basically he wants us to find out why arc profiling borks the preloader. Then the idea is it can be enabled just using CFLAGS. Until that happens though are you generating lcov output anywhere?

Re: Wine cabinet.dll FDI Conformace Test Patch

2005-02-28 Thread Daniel Kegel
Andreas wrote: It's an unspoken rule that preprocessor directives (#ifdef, ...) always start at the very beginning of a line to make sure one recognizes immediately which parts of the code are being processed and which ones aren't. Good point. I should have caught that style violation when I revie

Re: Wine cabinet.dll FDI Conformace Test Patch

2005-02-28 Thread Andreas Mohr
Hi, On Sun, Feb 27, 2005 at 10:21:15PM -0800, Rizwan Kassim wrote: > Folks, > > Aleksandr Liber and I have put together a set of tests for > cabinet.dll. Before we submit them to wine-patches, can anyone offer > any critiques/input? We plan to submit in a day or two. Cool stuff! It's wonder

Re: winmm test patch

2004-05-13 Thread Andreas Mohr
Hi, On Thu, May 13, 2004 at 07:30:27AM -0400, Robert Reif wrote: > Adds better error messages. Would probably be more useful to use an often-used construct like: #define DEVTYPE_TO_STR(dev) case dev: return #dev Andreas Mohr