> You can't use exception handlers in tests
I'm not sure why not, but I'll take you word of this.
Without exception handling the test cases for RtlCaptureStackBackTrace would
also always crash on Win 2000/NT so that makes all of the tests useless, I
think.
Well, at least I learned how to (/ n
Janne Hakonen writes:
> The test cases at http://source.winehq.org/patches/ are still in
> pending state. Should I improve them somehow, or leave them as they
> are?
I'm not sure that there's a good way of testing this. You can't use
exception handlers in tests, and you can't assume that ebp is
Ah, I see you had already corrected the stack overflowing, and found better way
even. :)
I tested the correction with the test cases and they passed.
I also tried AwesomiumGL and I couldn't get it to crash, so looks to me that
this bug is fixed.
The test cases at http://source.winehq.org/pat
>
> It doesn't need a try-except block, just better wrap-around handling.
>
Ah, you mean to enhance the if-check?
Well..., to me it seems that there is a problem with the 2nd check:
"(void *)(frame + 1) >= NtCurrentTeb()->Tib.StackBase"
If frame is 0x or close to it (e.g.
Janne Hakonen writes:
> Should I still add the try-except blocks to RtlCaptureStackBackTrace()
> and tests for 0xfffc value also?
It doesn't need a try-except block, just better wrap-around handling.
--
Alexandre Julliard
julli...@winehq.org
Hi Alexandre Julliard,
I see you had another idea of how to correct the RtlCaptureStackBackTrace()
function.
I tested your implementation with Anarchy Online's item store (ingame web
browser based on Awesomium) and with AwesomiumGL (sample app from Awesomium's
SDK).
With AwesomiumGL I did
> > If I need to make changes to, say, test cases, should I also send bug fix
> > patch again even if there is no changes to that?
>
> Please. If it is two separate patches, be sure to make it a series
> (label them 1/2, 2/2) and that the tests pass before/after each patch.
>
Ok, thanks for the
On Sun, Jan 30, 2011 at 22:15, Janne Hakonen wrote:
>>Also, it is custom to mark your resubmissions with corrections as [try x].
>> Makes it easier to determine what you are doing.
> I posted my patches to patches mailing list only once so far, so there
> hasn't been any retries yet.
> But, I shal
> Did you try this on WindowsXP or Windows7 to make sure that the
win_skip did not function on those platforms? My understanding is
that win_skip works on all Windows platforms not just WindowsNT or
Windows2000.
Well, I did test that skip doesn't happen on my home computer, whic
On 1/28/11 11:54 AM, Janne Hakonen wrote:
> Now, when I ran these tests on Testbot using all base VMs, the tests
were run also on W2KPROSP4 and WNT4WSSP6. However, the
> function seems to buggy in those. It throws access violation
whenever it is not skipping frames.
> Is there some way I could
> Now, when I ran these tests on Testbot using all base VMs, the tests were run
> also on W2KPROSP4 and WNT4WSSP6. However, the
> function seems to buggy in those. It throws access violation whenever it is
> not skipping frames.
> Is there some way I could prevent/skip these tests to be run on
Hi again,
I've been working to implement the tests for RtlCaptureStackBackTrace(), but I
have encountered a problem. The function, according to MSDN should be available
only in Windows XP and newer OSes.
Now, when I ran these tests on Testbot using all base VMs, the tests were run
also on W2
it is ok to do line wrapping and changing EOLs to CR LF. I
couldn't find an option to turn this feature off, but sending patches with
.patch extensions seems to prevent this formatting.
> I created a new signal.c file for the test case under ntdll/tests since
> I couldn’t find more fi
/2011 10:20 AM, Janne Hakonen wrote:
I created a new signal.c file for the test case under ntdll/tests since I
couldn’t find more fitting place.
Not a good idea. Please put the test into rtl.c
+static void test_pRtlCaptureStackBackTrace(void)
+{
+ok
Hi Janne,
I haven't reviewed your code, but I can suggest sending each
patch as a separate message to wine-patches, and using titles more like
ntdll: test corrupt stack frame in RtlCaptureStackBackTrace()
ntdll: handle corrupt stack frame in RtlCaptureStackBackTrace()
and mention clearly that t
that a resulting access violation is caught before it can crash the calling
> application.
>
> Second patch
> (0002-1-2-ntdll-tests-Added-a-test-for-RtlCaptureStackBackTr.txt) is a test
> case for the correction.
> It changes one of the frame pointers to invalid value and then
(0002-1-2-ntdll-tests-Added-a-test-for-RtlCaptureStackBackTr.txt) is a test
case for the correction.
It changes one of the frame pointers to invalid value and then calls
RtlCaptureStackBackTrace(). The test fails on Wine’s HEAD (without the first
patch), but passes successfully on Windows 7
On 3/2/2010 23:04, Reece Dunn wrote:
Hi,
TlsFree should return FALSE if there wasn't a TLS slot of the
specified index allocated, as well as returning
ERROR_INVALID_PARAMETER.
- Reece
- ok(TlsFree(tlsIndex)!=0,"TlsFree failed\n");
+ ok(TlsFree(tlsIndex)!=0,"TlsFree failed: %08x\n", Get
On 02/25/2010 08:35 AM, John Chow wrote:
This patch adds the test case for bug 18346: cmd does not support the
"^" escape character (http://bugs.winehq.org/show_bug.cgi?id=18346).
The test fails on Wine but passes on WineTestBot.
-John Chow
You forgot the patch (and also in the s
Dmitry Timoshkov writes:
> The test passes under XP SP3.
>
> ---
> dlls/gdi32/tests/dc.c | 43 ++-
> dlls/user32/painting.c | 17 -
> 2 files changed, 46 insertions(+), 14 deletions(-)
You'd want to verify this with class and windows
Michael Martin wrote:
This patch adds test for edit control clipboard context menu.
The test passes on Windows XP as the WM_COMMAND message is not sent to
the edit control by its context menu.
Fails on wine because wine does incorrectly send that message.
This problem shows up using the edit cl
On Tuesday 13 October 2009 08:46:59 am Dmitry Timoshkov wrote:
> +ret = pCryptImportKey(provider, (BYTE*)&key_blob,
> + sizeof(BLOBHEADER)+sizeof(DWORD)+key_length,
> + 0, CRYPT_IPSEC_HMAC_KEY, &hkey);
> +ok(ret, "CryptImportKey error %u\n", GetLas
"Michael Martin" wrote:
+WNDPROC editWndProc;
Should be static.
+static INT_PTR CALLBACK edit_control_wndproc(HWND hwnd, UINT msg, WPARAM
wparam, LPARAM lparam)
INT_PTR is wrong return type for a window proc.
+{
+static int timerCount = 0;
+HGLOBAL cbData;
+LPTSTR lptStrCop
> "Dan" == Dan Kegel writes:
Dan> That's how we used to do it, but tests showed that _filbuf really
Dan> has to do the cr removal.
Dan> On Jan 25, 2009 10:57 AM, "Uwe Bonnes" <
Dan> b...@elektron.ikp.physik.tu-darmstadt.de> wrote:
> "Dan" == Dan Kegel writes:
Dan>
I'll have a look...
On Fri, Oct 10, 2008 at 10:42:05AM +0200, Roderick Colenbrander wrote:
> +/* Try to create an OpenGL 3.0 contet */
content? context?
--
cu
pgpP3eMPpyjbs.pgp
Description: PGP signature
> Roderick Colenbrander wrote:
> > Hi,
> >
> > This is a resubmit of the same patch but not part of a series which
> contained a failing patch, so it should pass patchwatcher.
> >
> > Regards,
> > Roderick Colenbrander
> >
> >
> >
> >
> > --
Roderick Colenbrander wrote:
> Hi,
>
> This is a resubmit of the same patch but not part of a series which contained
> a failing patch, so it should pass patchwatcher.
>
> Regards,
> Roderick Colenbrander
>
>
>
>
>
>
>
JIM CAMERON wrote:
> The patch for cursor loading caused some existing
> tests to succeed inside todo blocks. This patch
> removes those todo and adds a regression test for CreateIconFromResource().
>
>
>
>
>
Hi,
That mea
On Dec 5, 2007 10:35 PM, Lei Zhang <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I'm moving the current tests into their own function in preparation to
> write more tests.
>
When submitting a numbered patch series, can you put the numbers [x/y]
right after the module name? That makes it easier to spot the
On 1/30/07, Dmitry Timoshkov wrote:
Then probably DrawText(DT_CALCRECT) could better suit your needs.
Almost on the bull's-eye! Actually, DrawText() returns the *height* of
the string... how lucky I am, huh?
But a "See Also" link in the MSDN page for DrawText() [1] pointed me
to TabbedTextOu
"Pedro Araujo Chaves Jr." <[EMAIL PROTECTED]> wrote:
Here's the picture: when an application calls TextOut() for printing
text, the usual (at least in my case) call sequence in Wine is
TextOut()
TextOutA()
ExtTextOutA()
ExtTextOutW() (the one I patched)
GetTextExtentPointW()
GetTextExtentPoint3
On 2007-01-29, Duane Clark wrote:
GetTextExtentPoint32
For some examples in Wine, look at almost any control in comctl32.
I was afraid somebody would answer that... Thanks for the quick reply,
but that isn't exactly what I need.
Here's the picture: when an application calls TextOut() for prin
Pedro Araujo Chaves Jr. wrote:
I've just finished writing a test case for Bug 50, but I'm missing *a
single thing* that prevents it from working under Windows: I still
don't know how to get the width of the text output by ExtTextOutW().
GetTextExtentPoint32
For some examples i
I've just finished writing a test case for Bug 50, but I'm missing *a
single thing* that prevents it from working under Windows: I still
don't know how to get the width of the text output by ExtTextOutW().
MSDN isn't helping much, and I haven't found the optimal Googl
Update...
I thought I had managed to get Keith's idea and make up a patch, but,
to great grief -- and not so great a surprise --, I have just
discovered that my patch for bug 50 is not as effective on Lotus Notes
6.5.3 as it was in Notes R5 and the Petzold justify1 example.
Well, I'm checking so
I think I've managed to patch [1] bug 50 [2], but I'm having a little
trouble coming up with a proper test case...
I'm already at it, studying and investigating, but could someone test that,
too?
[1] http://bugs.winehq.org/attachment.cgi?id=4543&action=view
[2] htt
Dan Kegel wrote:
Piero Proietti wrote a nice demo app in VB6
which embeds a browser window. It doesn't
work in Wine. I think Jacek has been committing
patches that ought to help this
( e.g. http://winehq.org/pipermail/wine-cvs/2006-July/024993.html )
but it's not quite there yet.
Yes, it shoul
etc?
Also, a very simple test case for this is our very own HTML Help
viewer, hh and hhctrl.ocx.
--
James Hawkins
Piero Proietti wrote a nice demo app in VB6
which embeds a browser window. It doesn't
work in Wine. I think Jacek has been committing
patches that ought to help this
( e.g. http://winehq.org/pipermail/wine-cvs/2006-July/024993.html )
but it's not quite there yet.
Piero's willing to tailor the te
an Kegel" <[EMAIL PROTECTED]>
>To: wine-devel
>Subject: re: test case for MSI problem in America's Army installer
>Date: Fri, 2 Jun 2006 07:06:30 -0700
>
>Mike M. wrote:
>>>>[America's Army install crashes, see
>>>>http://bugs.winehq.org/sh
Mike M. wrote:
[America's Army install crashes, see
http://bugs.winehq.org/show_bug.cgi?id=5139 ]
This is as close as I will be able to come to including a test case, as
this is how I obtained my results.
If you want me to fix the problem, please submit a regression test to
wine-patches
EA Durbin wrote:
This is as close as I will be able to come to including a test case, as
this is how I obtained my results.
If you want me to fix the problem, please submit a regression test to
wine-patches with a todo_wine{} around the code that doesn't work.
thanks,
Mike
t; thought is that this is the right and correct thing to do.
>>
>> you haven't even shown real windows behaviour, or a test case.
> COULD SOMEONE KNOWLEDGEABLE IN MinMax STUFF KINDLY POINT ME AT: WHAT
> EXACTLY NEEDS TO BE TESTED Re: ABOVE MENTIONED PATCH + A GUIDE HOW TO
>
n't even shown real windows behaviour, or a test case.
COULD SOMEONE KNOWLEDGEABLE IN MinMax STUFF KINDLY POINT ME AT: WHAT
EXACTLY NEEDS TO BE TESTED Re: ABOVE MENTIONED PATCH + A GUIDE HOW TO
CREATE A WINE TEST CASE?
(mail quantity doesn't work, maybe turning the volume knob up will :-&g
We changed our program to avoid the needless polling (only two PeekMessage are
needet then). We add also the PM_NOYIELD. This gives back the reaction of the
program if some other process consumes process time. But the speed is more
reduced than windows.
Your patch works for our program. It seems i
Oliver Mössinger wrote:
We changed our program to avoid the needless polling (only two PeekMessage are
needet then). We add also the PM_NOYIELD. This gives back the reaction of the
program if some other process consumes process time. But the speed is more
reduced than windows.
So we actually go
Jeremy White <[EMAIL PROTECTED]> writes:
> However, this makes it clear to me that the yield
> in message.c is largely moot; you need to remove both
> that one and the one in ntdll/sync.c to have
> any material effect on Wine timing with messages.
Actually it should be enough to not yield in MsgW
I dug into this a bit further.
Felix, the extra 100 yields are coming from code I
prompted, in ntdll/sync.c; if the return from
an NtWait... is TIMEOUT, then we force a yield.
(The thread that points to more info is here:
http://www.winehq.org/hypermail/wine-devel/2005/01/0469.html)
If I back tha
Felix Nawothnig <[EMAIL PROTECTED]> writes:
> I meant that using shm generally would lower the cost of a server
> request and doing that extra yield would no longer be necessary
> (although we'd still have the other yield due to the request itself
> unless the queue is put into shm).
If you mean
I wrote:
since a server call is much more expensive than a Windows system call.
Would using shm fix that?
No, you don't want to put the message queue in shared memory, that's
not reliable.
shm + kernel handles for synchronization then?
Wait, putting the message queue into shm isn't what I wa
Jeremy White <[EMAIL PROTECTED]> writes:
> But I have to admit I'm bothered; you seem to be refusing
> a patch that makes Wine more correct.
>
> PeekMessage() is more lightweight on Windows than it is on Wine, but
> I can still write bad code that chokes the system by spin looping on
> PeekMessage
Alexandre Julliard wrote:
since a server call is much more expensive than a Windows system call.
Would using shm fix that?
No, you don't want to put the message queue in shared memory, that's
not reliable.
shm + kernel handles for synchronization then?
Felix
Alexandre Julliard wrote:
> Felix Nawothnig <[EMAIL PROTECTED]> writes:
>
>
>>But then that "extra" NtYieldExecution should not depend on
>>!PM_NOYIELD since PM_NOYIELD doesn't have any effect on Windows, right?
>
>
> It has an effect for Win16 apps, they need to release the Win16
> lock. We co
Felix Nawothnig <[EMAIL PROTECTED]> writes:
> But then that "extra" NtYieldExecution should not depend on
> !PM_NOYIELD since PM_NOYIELD doesn't have any effect on Windows, right?
It has an effect for Win16 apps, they need to release the Win16
lock. We could add a yield in the PM_NOYIELD case, bu
Alexandre Julliard wrote:
So, PeekMessage always yields execution (it shouldn't) with PM_NOYIELD
specified it yields execution twice (although it shouldn't at all).
PeekMessage is going to call the server and wait on the result,
there's no way around it. The extra yield is to avoid hammering the
Felix Nawothnig <[EMAIL PROTECTED]> writes:
> (The numbers slightly differ between runs for obvious reasons but they
> are close enough (with an error margin of +/- 10 we could maybe make
> this a real testcase))
>
> So, PeekMessage always yields execution (it shouldn't) with PM_NOYIELD
> specifie
I wrote:
So, PeekMessage always yields execution (it shouldn't) with PM_NOYIELD
specified it yields execution twice (although it shouldn't at all).
Err, that should read "and without PM_NOYIELD specified".
Felix
Alexandre Julliard wrote:
You can probably fix it by passing PM_NOYIELD in the PeekMessage
calls. But if your app needs a lot of CPU, restructuring the code to
avoid all the needless polling would give much better results, and
probably improve the behavior on Windows too.
That's just a workarou
Oliver Mössinger <[EMAIL PROTECTED]> writes:
> Hi wine-devel,
>
> attached i have a test case whitch demonstates the differece between Windows
> and wine. There is also a sample program 'TEST.CPP' attached.
>
> On Windows XP
> - Start 'test.exe
ome light on what the
reason behind this would be?
Attached is a small test case that demonstrates a problem in Wine's
compare string. Explanation:
The word "Mohammad" is spelled in Arabic Meem, Hah, Meem, Shadda, Dal.
The Shadda's purpose is to double the pronunciation of the pr
Dmitry Timoshkov wrote:
"Mike McCormack" <[EMAIL PROTECTED]> wrote:
The flag (0x1000) passed to CompareString reverse the sort order of
a number of unicode characters. I've got no idea why it would want to
do that... maybe somebody can shed some light on what the reason behind
this would
"Mike McCormack" <[EMAIL PROTECTED]> wrote:
> The flag (0x1000) passed to CompareString reverse the sort order of
> a number of unicode characters. I've got no idea why it would want to
> do that... maybe somebody can shed some light on what the reason behind
> this would be?
Just a shot
icode
characters... it took a while to run :)
The flag (0x1000) passed to CompareString reverse the sort order of
a number of unicode characters. I've got no idea why it would want to
do that... maybe somebody can shed some light on what the reason behind
this would be?
Mike
ChangeLog:
*
Dmitry Timoshkov <[EMAIL PROTECTED]> writes:
> I don't see why it's needed because there is no a visual hang, system
> menu gets displayed. This is exactly the same behaviour as pressing
> Left arrow on the most left item of a window menu, so I vote to remove
> this code from the patch:
But this
On January 30, 2004 08:08 am, Dmitry Timoshkov wrote:
> Hello,
>
> Changelog:
> Dmitry Timoshkov <[EMAIL PROTECTED]>
> Add a test case and a fix for the window styles state
> at the window creation time.
>
SNIP
> +cs->style |= WS_CAPT
66 matches
Mail list logo
