Re: Start: Convert start to Unicode. [try7]

Dan Kegel wrote: > Anatoly, > thank you for working to fix "start" to work better for Unicode, > I should have done that originally. > > You are welcome. :) > But you seem to be having trouble getting the patch in, > so here's what little advice I can give: > > If there is any difference between

re: Start: Convert start to Unicode. [try7]

Anatoly, thank you for working to fix "start" to work better for Unicode, I should have done that originally. But you seem to be having trouble getting the patch in, so here's what little advice I can give: If there is any difference between versions of your patch, you should describe it in the p

Re: Start: Convert start to Unicode. [try5]

Alexandre Julliard wrote: > No, what you need is one function for errors that can happen in normal > usage (file not found, invalid option etc.) that is Unicode and > localized, and one function for internal errors (LoadString failures > etc.) that simply uses WINE_ERR with an English message. > >

Re: Start: Convert start to Unicode. [try5]

Anatoly Lyutin <[EMAIL PROTECTED]> writes: > @@ -202,9 +246,9 @@ int main(int argc, char *argv[]) > DWORD waitcode; > waitcode = WaitForSingleObject(sei.hProcess, INFINITE); > if (waitcode) > - fatal_error("WaitForSingleObject", GetLast

Re: Start: Convert start to Unicode. [try4]

"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: > Changelog: > Convert start.exe to Unicode. Please carefully check buffer sizes passed to Win32 APIs. -- Dmitry.

Re: Start: Convert start to Unicode.

Michael Stefaniuc wrote: > Anatoly Lyutin wrote: > >> Dmitry Timoshkov wrote: >> >>> "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: >>> >>> >>> The whole Wine tree uses 8 spaces for a tab. >>> >>> >>> >> Hm. I thought that some modules use 4 space symbols instead of 1 tab >> symb

Re: Start: Convert start to Unicode.

Anatoly Lyutin wrote: > Dmitry Timoshkov wrote: >> "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: >> >> >> The whole Wine tree uses 8 spaces for a tab. >> >> > Hm. I thought that some modules use 4 space symbols instead of 1 tab > symbol. Sorry if I am wrong. I think you are confusing indentati

Re: Start: Convert start to Unicode.

Dmitry Timoshkov wrote: > "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: > > > The whole Wine tree uses 8 spaces for a tab. > > Hm. I thought that some modules use 4 space symbols instead of 1 tab symbol. Sorry if I am wrong. > > A proper error handling IMO is to return an error to the caller i

Re: Start: Convert start to Unicode.

"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: >> Once you change your editor settings to use natural 8 spaces for a tab >> you will >> see how ugly the formatting in your new code is. >> > I am sorry. I forgot that in the start.c uses natural 8 spaces for a > tab. Fixed. The whole Wine tree uses

Re: Start: Convert start to Unicode.

Dmitry Timoshkov wrote: > "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: > >> -/** >> +WINE_DEFAULT_DEBUG_CHANNEL(start); >> + >> +/* > > All these changes /** -> /* make the diff larger, and are not really > necessary. I have considered it in the new version. > > >> Output given message to stdout wi

Re: Start: Convert start to Unicode.

"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: > -/** > +WINE_DEFAULT_DEBUG_CHANNEL(start); > + > +/* All these changes /** -> /* make the diff larger, and are not really necessary. > Output given message to stdout without formatting. > */ > -static void output(const char *message) > +static void