On December 2, 2003 03:40 am, Casper Hornstrup wrote:
> Great. I have a few more patches at http://212.242.245.122/patches/.
> Maybe you can review them?
It's better to post them on the list. More people get to see them,
they get indexed by various search engines, and they get archived
for posteri
: [EMAIL PROTECTED]; [EMAIL PROTECTED]
> Emne: Re: Splitting out shared Win16/Win32 code
>
>
> > You're right. I should have written MMDRV_PhysicalFeatures. See
> > attached patch.
> ooops, I forgot to submit the fix I had for that back to
> wine... This should
You're right. I should have written MMDRV_PhysicalFeatures.
See attached patch.
ooops, I forgot to submit the fix I had for that back to wine...
This should be a better fix, whithout code duplication
A+
--
Eric Pouech
Name: mm16
ChangeLog: - move usage of 16 bit specific functions (Map
> -Oprindelig meddelelse-
> Fra: Eric Pouech [mailto:[EMAIL PROTECTED]
> Sendt: 30. november 2003 16:35
> Til: Casper Hornstrup
> Cc: 'wine-devel'
> Emne: Re: Splitting out shared Win16/Win32 code
>
>
> Casper Hornstrup wrote:
> > Dlls/win
Steven Edwards <[EMAIL PROTECTED]> writes:
> It submitted a patch for this problem a while back in comdlg32 and it
> went to the silent void that is Alexandres patch rejection que
> http://www.winehq.org/hypermail/wine-patches/2003/10/0265.html
Can't say that I remember that patch, I must hav
Casper Hornstrup wrote:
Dlls/winmm/lolvldrv.c has a function (MMDRV_Message) shared by the
Win16 and the Win32 implementation of mmsystem. Since it is shared
by both mmsystem.dll and winmm.dll, all Win16 APIs used in the shared
functions will be imported by the Win32 implementation (winmm.dll)
also
On November 29, 2003 03:59 pm, Casper Hornstrup wrote:
> 2) Duplicate the shared code in a Win32 specific file and Win16
> specific file.
I haven't looked if the code can be duplicated, but by the size
of the function (it's not big), I'd say duplicating is the way
to go (added bonus if by doing so
Hello Capser,
--- Casper Hornstrup <[EMAIL PROTECTED]> wrote:
> Dlls/winmm/lolvldrv.c has a function (MMDRV_Message) shared by the
> Win16 and the Win32 implementation of mmsystem. Since it is shared
> by both mmsystem.dll and winmm.dll, all Win16 APIs used in the shared
> functions will be import
Dlls/winmm/lolvldrv.c has a function (MMDRV_Message) shared by the
Win16 and the Win32 implementation of mmsystem. Since it is shared
by both mmsystem.dll and winmm.dll, all Win16 APIs used in the shared
functions will be imported by the Win32 implementation (winmm.dll)
also. On ReactOS no such API
