Ryan Miller wrote:
> ws2_32: Fixed bug with sockets randomly resetting due to GetLastError being
> reset by setsockopt in Windows, but not in Wine. Also included is the
> associated test.
>
> +SetLastError(1);
Please use more accepted value of 0xdeadbeef
Vitaliy
Michael Stefaniuc <[EMAIL PROTECTED]> writes:
> find -name '*.[ch]' | xargs grep 'SetLastError( *0 *)' | wc -l
> 117
>
> Time for a new Janitorial mini task?
No, SetLastError(0) is fine.
--
Alexandre Julliard
[EMAIL PROTECTED]
James Hawkins wrote:
> On 9/8/06, Ryan Miller <[EMAIL PROTECTED]> wrote:
>> +/* In Windows, if setsockopt succeeds, GetLastError() always
>> returns zero.
>> + The native wininet.dll expects this behavior, and does not always
>> + check the return value of setsockopt() first.*/
>> +
On 9/8/06, Ryan Miller <[EMAIL PROTECTED]> wrote:
Index: ChangeLog
===
RCS file: /home/wine/wine/ChangeLog,v
retrieving revision 1.120
diff -u -r1.120 ChangeLog
--- ChangeLog 24 Aug 2006 14:43:25 - 1.120
+++ ChangeLog 8
On 9/8/06, Ryan Miller <[EMAIL PROTECTED]> wrote:
Index: ChangeLog
You don't want to change the changelog, only AJ does the changelog
once the patch is accepted and makes its way into main line Wine.
You should just add a note of what changed
Tom