Re: Shwapi updates

2004-09-13 Thread James Hawkins
> Aside from the tests, what constitutes independent? If the functions do not rely on each other, then they are independent of each other. You can leave it the way it is, but it was a suggestion to help from the case where say one of the functions has an error in it. If that is the case then non

Re: Shwapi updates

2004-09-13 Thread Alexandre Julliard
Jon Griffiths <[EMAIL PROTECTED]> writes: > Aside from the tests, what constitutes independent? These are all new > functions so there is no possibility of regressions, which is the > main reason to split up patches. Ease of understanding/reviewing the > patches is the other main reason, but each

Re: Shwapi updates

2004-09-13 Thread Jon Griffiths
Hi James, > Can this patch be broken up into smaller, independent parts? It's > more likely to be committed if that is the case. Aside from the tests, what constitutes independent? These are all new functions so there is no possibility of regressions, which is the main reason to split up patches

Re: Shwapi updates

2004-09-12 Thread James Hawkins
Can this patch be broken up into smaller, independent parts? It's more likely to be committed if that is the case. On Sun, 12 Sep 2004 08:55:27 -0700 (PDT), Jon Griffiths <[EMAIL PROTECTED]> wrote: > Cheers, > Jon > >+dlls/shlwapi/shlwapi.spec dlls/shlwapi/ordinal.c > Implement SHSimula