Re: SHLWAPI: implement PathIsValidChar{A,W}

2005-01-31 Thread Juan Lang
Hi Hans, > Yes I contemplated that but then you reintroduce a conditional in > the ascii case ( if (c > 0x7e) ), which somewhat defeats the > purpose of using a lookup table. Defeats? I don't think so. A single comparison that covers a large number of cases is different than a cascade of compar

Re: SHLWAPI: implement PathIsValidChar{A,W}

2005-01-31 Thread Hans Leidekker
On Sunday 30 January 2005 22:29, Juan Lang wrote: > Hi Hans, it looks like from values 0x7e onward the character class is > always PATH_CHAR_CLASS_OTHER_VALID. If you like, for clarity you can fill > in the value through 0x7f, but having a lookup table beyond this isn't > necessary. Yes I contem

Re: SHLWAPI: implement PathIsValidChar{A,W}

2005-01-30 Thread Juan Lang
Hi Hans, it looks like from values 0x7e onward the character class is always PATH_CHAR_CLASS_OTHER_VALID. If you like, for clarity you can fill in the value through 0x7f, but having a lookup table beyond this isn't necessary. Also, that means the data type can be unsigned char, not DWORD. And, i