Re: SHELL32: cleanup, create unicode versions of some functions

2005-02-22 Thread Mike McCormack
Alexandre Julliard wrote: Actually the right way to get rid of them is to convert to Unicode. In the few cases where we actually have to work with Ansi characters they will most likely be in the Unix codepage and then switching to lstrcmpiA would be wrong. I'm on the way to converting some of the s

Re: SHELL32: cleanup, create unicode versions of some functions

2005-02-22 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > Almost all of them can be directly replaced by lstrcmpiA, the exceptions are: Actually the right way to get rid of them is to convert to Unicode. In the few cases where we actually have to work with Ansi characters they will most likely be in the U

Re: SHELL32: cleanup, create unicode versions of some functions

2005-02-21 Thread Dmitry Timoshkov
"Mike McCormack" <[EMAIL PROTECTED]> wrote: > There's quite a few strcasecmp calls revealed by: > > find . -name \*.c -exec grep strcasecmp {} \; -ls > > We probably need somebody to go through and clean them all up. Maybe a > janitorial task? Almost all of them can be directly replaced by ls

Re: SHELL32: cleanup, create unicode versions of some functions

2005-02-21 Thread Mike McCormack
-if (strcasecmp ( szData1, szData2 )!=0 ) +if (strcasecmp( szData1, szData2 )) As a common rule strcasecmp should never be used in Wine code, since it introduces problem with portability and unexpected side effects when locale of the underlying system differs from a Wine one. You

Re: SHELL32: cleanup, create unicode versions of some functions

2005-02-21 Thread Dmitry Timoshkov
"Mike McCormack" <[EMAIL PROTECTED]> wrote: > ChangeLog: > * cleanup, create unicode versions of _ILCreateFromPath, > _ILCreateGuidFromStr, and _ILCreateFromFindData > @@ -524,7 +516,7 @@ BOOL WINAPI ILIsEqual(LPCITEMIDLIST pidl > _ILSimpleGetText(pidltemp1, szData1, MAX_PATH); >