Re: [2/2] shell32: Be safe against removal of entries in SHChangeNotify

2011-09-20 Thread Piotr Caban
Hi, On 09/19/11 20:52, André Hentschel wrote: @@ -325,7 +325,7 @@ void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID dwItem1, LPCVOID EnterCriticalSection(&SHELL32_ChangenotifyCS); /* loop through the list */ -LIST_FOR_EACH_ENTRY( ptr,¬ifications, NOTIFICATION

Re: Behavior of SHChangeNotify

2011-06-25 Thread Jay Yang
On 06/24/2011 03:55 PM, Andrew Eikum wrote: > On 06/24/2011 12:27 PM, Jay Yang wrote: >> To try to implement copy-paste for shell folders, I used SHFileOperation for >> the actual copy. SHFileOperation calls SHChangeNotify to notify listeners >> about changes to the file

Re: Behavior of SHChangeNotify

2011-06-24 Thread Andrew Eikum
On 06/24/2011 12:27 PM, Jay Yang wrote: To try to implement copy-paste for shell folders, I used SHFileOperation for the actual copy. SHFileOperation calls SHChangeNotify to notify listeners about changes to the file system. But I noticed that the shell view would not update correctly if it

Behavior of SHChangeNotify

2011-06-24 Thread Jay Yang
To try to implement copy-paste for shell folders, I used SHFileOperation for the actual copy. SHFileOperation calls SHChangeNotify to notify listeners about changes to the file system. But I noticed that the shell view would not update correctly if it was at 'C:\' but it would if

Re: [PATCH 3/4] shell32: Some events are sent twice in SHChangeNotify

2010-11-13 Thread Andrew Eikum
Obviously this needs some work yet. 1, 2, and 4 should work fine without this patch. On 11/12/2010 11:29 PM, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could

Re: [PATCH 3/4] shell32: Some events are sent twice in SHChangeNotify

2010-11-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7032 Your paranoid android.

Re: [PATCH 2/2 (resend)] shell32: Also compare UNIX realpaths in SHChangeNotify

2010-08-04 Thread Andrew Eikum
On 08/04/2010 08:50 AM, Alexandre Julliard wrote: Andrew Eikum writes: User calls SHChangeNotifyRegister with a PIDL like "[Desktop][C:]". The shell (or whatever) calls SHChangeNotify with a PIDL in the UNIX filesystem, like "[Desktop][/][home][user][.wine][drive_c]".

Re: [PATCH 2/2 (resend)] shell32: Also compare UNIX realpaths in SHChangeNotify

2010-08-04 Thread Alexandre Julliard
Andrew Eikum writes: > User calls SHChangeNotifyRegister with a PIDL like "[Desktop][C:]". > The shell (or whatever) calls SHChangeNotify with a PIDL in the UNIX > filesystem, like "[Desktop][/][home][user][.wine][drive_c]". These > should result in a match an

Re: [PATCH 2/2 (resend)] shell32: Also compare UNIX realpaths in SHChangeNotify

2010-08-04 Thread Andrew Eikum
On 08/04/2010 05:24 AM, Alexandre Julliard wrote: Andrew Eikum writes: This fixes bug 18606. It's possible to refer to the same file in two different ways with PIDLs in Wine. This can cause notifications via SHChangeNotify to fail to trigger. To ensure an apples-to-apples compa

Re: [PATCH 2/2 (resend)] shell32: Also compare UNIX realpaths in SHChangeNotify

2010-08-04 Thread Alexandre Julliard
Andrew Eikum writes: > This fixes bug 18606. > > It's possible to refer to the same file in two different ways with PIDLs > in Wine. This can cause notifications via SHChangeNotify to fail to > trigger. To ensure an apples-to-apples comparison, we convert the > incomin

RFC: Standardize paths in shell32.SHChangeNotify [Bug 18606]

2010-06-14 Thread Andrew Eikum
Hey folks, I have a fix here for bug 18606. I think it's decent, but I could use another few sets of eyes to make sure I didn't miss anything, or even that I'm not way on the wrong track. The problem and solution are described in patch 3. In brief, SHChangeNotify notifies

SHChangeNotify()

2007-10-27 Thread Francois Gouget
shlwapi.spec exports SHChangeNotify. However I see no implementation of this function in shlwapi. There is an SHChangeNotifyWrap() function however. Weirder still, SHChangeNotifyWrap() does not seem to be called anywhere, is not exported by shlwapi.spec, and calls SHChangeNotify(). So I&#