Hi Alexandre
The only explanation was "it breaks the testcase X", where X is a
testcase that doesn't even pass on Windows 9x. I think the patch won't
break any real application.
Famous last words. There have been a number of similar hacks done in
the menu code already, but they all had to be r
Michael Kaufmann <[EMAIL PROTECTED]> writes:
> The only explanation was "it breaks the testcase X", where X is a
> testcase that doesn't even pass on Windows 9x. I think the patch won't
> break any real application.
Famous last words. There have been a number of similar hacks done in
the menu cod
Hi Dmitry
How do you define the "real behavior" ?
That's a behaviour of an existing product that could be tested and confirmed.
So is there an existing third-party program that depends on the "real
behavior" ?
Have
you checked that Windows 2003 still passes this test?
No, I don't.
Hi Uwe
Micheal,
can we perhaps create a test case, that mimics the Delphi behaviour and
succeeds on WinXX but fails on Wine? Then the behaviour is well documented
and there is less reason to not fix it while breaking another test.
Yes, that's a good idea! I've attached a test case that fails onl
> Until then, many
> Delphi apps won't work. For me, this is not acceptable.
For me, it's not acceptable to debate an inclusion of a not acceptable
solution, there were enough explanations why it's not acceptable. You are
welcome to fix it properly though.
Please don't take my words offensively,
"Michael Kaufmann" <[EMAIL PROTECTED]> wrote:
> How do you define the "real behavior" ?
That's a behaviour of an existing product that could be tested and confirmed.
> The behavior of Windows XP?
Including it as well.
> Have
> you checked that Windows 2003 still passes this test?
No, I don't
> "Michael" == Michael Kaufmann <[EMAIL PROTECTED]> writes:
...
Michael> I promise that I'll remember you to reactivate this
Michael> testcase. If we don't modify DestroyMenu NOW, there's also a
Michael> good chance that this bug will never be fixed. Remember, a lot
Michael> o
Hi Dmitry
My last menu patch didn't pass a test case. I've commented out this test
case, because it tests undocumented behavior.
That's a very bad idea, then you need to comment out half of the test
cases in Wine. The tests show *the real* behaviour, it doesn't really
matter whether it's docu
"Michael Kaufmann" <[EMAIL PROTECTED]> wrote:
> My last menu patch didn't pass a test case. I've commented out this test
> case, because it tests undocumented behavior.
That's a very bad idea, then you need to comment out half of the test
cases in Wine. The tests show *the real* behaviour, it do
Hi all
My last menu patch didn't pass a test case. I've commented out this test
case, because it tests undocumented behavior. We should re-activate this
testcase as soon as WINE passes it. This will be the case when the menu
code is moved to WineServer, as Dmitry pointed out.
I've also added mo
10 matches
Mail list logo
