Re: Resubmit user32: TrackPopupMenu(Ex) fixes

2009-03-06 Thread Reece Dunn
2009/3/6 Rein Klazes : > Reece Dunn schreef: >> >> = Implementation Comments: >> >> +    /* FIXME: this check is performed several times, here and in the >> called >> +       functions. That could be optimized */ >> +    if( !hMenu || !MENU_GetMenu( hMenu )) { >> +        SetLastError( ERROR_INVALI

Re: Resubmit user32: TrackPopupMenu(Ex) fixes

2009-03-06 Thread Rein Klazes
Reece Dunn schreef: = Implementation Comments: +/* FIXME: this check is performed several times, here and in the called + functions. That could be optimized */ +if( !hMenu || !MENU_GetMenu( hMenu )) { +SetLastError( ERROR_INVALID_MENU_HANDLE) ; +return FALSE; +}

Re: Resubmit user32: TrackPopupMenu(Ex) fixes

2009-03-06 Thread Reece Dunn
2009/3/6 Rein Klazes : > Hi, > > Several rounds of commits have gone by without this patch. > I thought it was rather noncontroversial, there must > be something that I am overlooking. Can I get a hint please? > > (cleaned up some white space errors, otherwise patch is unchanged. ) > > Fix another