Re: Resent^2 : Zero out return string in GetMenuStr

2005-03-29 Thread Uwe Bonnes
> "Alexandre" == Alexandre Julliard <[EMAIL PROTECTED]> writes: Alexandre> Uwe Bonnes <[EMAIL PROTECTED]> writes: >> Anything wrong with this patch? >> >> Changelog: dlls/user/menu.c: GetMenuStrA|W Initialize return string >> as an empty string Alexandre> You need to

Re: Resent^2 : Zero out return string in GetMenuStr

2005-03-29 Thread Alexandre Julliard
Uwe Bonnes <[EMAIL PROTECTED]> writes: > Alexandre, > > also before, there was a NULL written to position Zero of the > string. However there where some checks and function calls that could > return Zero but didn't touch the string. Now there is only a check > that the argument is a pointer befo

Re: Resent^2 : Zero out return string in GetMenuStr

2005-03-29 Thread Alexandre Julliard
Uwe Bonnes <[EMAIL PROTECTED]> writes: > Anything wrong with this patch? > > Changelog: > dlls/user/menu.c: GetMenuStrA|W > Initialize return string as an empty string You need to take the specified length into account before writing to the string. -- Alexandre Julliard [EMAIL PROT