Re: Resend patch for 15494

2008-10-09 Thread Roderick Colenbrander
The whole issue is a driver bug (the drmMap issue related to lack of virtual memory caused by Wine). This causes CreateSurface to fail. Though there can also be other reasons why CreateSurface can fail (though not in this case). The test should just for the failure of creating surfaces and then

Re: Resend patch for 15494

2008-10-08 Thread Chris Ahrendt
James Hawkins wrote: > On Wed, Oct 8, 2008 at 10:17 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> James Hawkins wrote: >>> On Wed, Oct 8, 2008 at 10:12 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: Actually it was rejected because Dan's network went down and crashed patchwatcher.. >

Re: Resend patch for 15494

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 10:17 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> >> On Wed, Oct 8, 2008 at 10:12 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >>> >>> Actually it was rejected because Dan's network went down and crashed >>> patchwatcher.. >>> >> >> Alexandre does n

Re: Resend patch for 15494

2008-10-08 Thread Chris Ahrendt
James Hawkins wrote: > On Wed, Oct 8, 2008 at 10:12 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> Actually it was rejected because Dan's network went down and crashed >> patchwatcher.. >> > > Alexandre does not receive notices from patchwatcher, nor does he rely > on the patchwatcher results whe

Re: Resend patch for 15494

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 10:12 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> > Actually it was rejected because Dan's network went down and crashed > patchwatcher.. > Alexandre does not receive notices from patchwatcher, nor does he rely on the patchwatcher results when reviewing patches... -- J

Re: Resend patch for 15494

2008-10-08 Thread Chris Ahrendt
James Hawkins wrote: > On Wed, Oct 8, 2008 at 10:05 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> It was not a broad sweep... I know where it crashed and am checking there. >> However, I noticed there were several other places were at sometimes it >> checked for null and other places it did not..

Re: Resend patch for 15494

2008-10-08 Thread James Hawkins
On Wed, Oct 8, 2008 at 10:05 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> > It was not a broad sweep... I know where it crashed and am checking there. > However, I noticed there were several other places were at sometimes it > checked for null and other places it did not.. so I went > through an

Re: Resend patch for 15494

2008-10-08 Thread Chris Ahrendt
James Hawkins wrote: > 2008/10/8 Chris Ahrendt <[EMAIL PROTECTED]>: >> per dan resending >> >> >> chris >> >> From e8ec03471e1206ea93fa6224d7c6b8b61422d80e Mon Sep 17 00:00:00 2001 >> From: Chris Ahrendt <[EMAIL PROTECTED]> >> Date: Tue, 7 Oct 2008 21:02:36 -0400 >> Subject: [PATCH] Checked all the

Re: Resend patch for 15494

2008-10-08 Thread James Hawkins
2008/10/8 Chris Ahrendt <[EMAIL PROTECTED]>: > per dan resending > > > chris > > From e8ec03471e1206ea93fa6224d7c6b8b61422d80e Mon Sep 17 00:00:00 2001 > From: Chris Ahrendt <[EMAIL PROTECTED]> > Date: Tue, 7 Oct 2008 21:02:36 -0400 > Subject: [PATCH] Checked all the states of variables in test to