Re: Resend: Another fix for kernel file test

2003-12-14 Thread Ferenc Wagner
Alexandre Julliard <[EMAIL PROTECTED]> writes: > Ferenc Wagner <[EMAIL PROTECTED]> writes: > >> What's your policy if it's not possible? Like in my (unapplied) >> http://www.winehq.org/hypermail/wine-patches/2003/10/0411.html >> patch, where tests are done in a loop, and some of them succeed, >>

Re: Resend: Another fix for kernel file test

2003-12-14 Thread Hans Leidekker
On Sunday 14 December 2003 22:04, Ferenc Wagner wrote: > What's your policy if it's not possible? Like in my (unapplied) > http://www.winehq.org/hypermail/wine-patches/2003/10/0411.html > patch, where tests are done in a loop, and some of them succeed, > some fail? Or is there something else wro

Re: Resend: Another fix for kernel file test

2003-12-14 Thread Alexandre Julliard
Ferenc Wagner <[EMAIL PROTECTED]> writes: > What's your policy if it's not possible? Like in my (unapplied) > http://www.winehq.org/hypermail/wine-patches/2003/10/0411.html > patch, where tests are done in a loop, and some of them succeed, > some fail? Or is there something else wrong with that

Re: Resend: Another fix for kernel file test

2003-12-14 Thread Hans Leidekker
On Sunday 14 December 2003 21:23, Alexandre Julliard wrote: > You need to fix the code too, or add a todo_wine; I can't commit tests > that fail. Of course, you're right. Here's a fix. Changelog: MoveFile returns ERROR_ALREADY_EXISTS, not ERROR_FILE_EXISTS Index: files/file.c ===

Re: Resend: Another fix for kernel file test

2003-12-14 Thread Ferenc Wagner
Alexandre Julliard <[EMAIL PROTECTED]> writes: > You need to fix the code too, or add a todo_wine; I can't > commit tests that fail. What's your policy if it's not possible? Like in my (unapplied) http://www.winehq.org/hypermail/wine-patches/2003/10/0411.html patch, where tests are done in a lo

Re: Resend: Another fix for kernel file test

2003-12-14 Thread Alexandre Julliard
Hans Leidekker <[EMAIL PROTECTED]> writes: > Tested on Win2k and Win98. MoveFile returns ERROR_ALREADY_EXISTS > when the destination exists. > > -Hans > > Changelog > MoveFile returns ERROR_ALREADY_EXISTS, not ERROR_FILE_EXISTS You need to fix the code too, or add a todo_wine; I can't commit t