Re: Request for Review: Cursor & Icon patches

2009-07-25 Thread Frédéric Delanoy
On 07/25/2009 08:21 PM, Daniel Santos wrote: >> Anyway Alexandre is on holiday next week, so you'll have to >> wait a bit to get his comments. > > Yea, that's what I was afraid of. > > As far as the chunks, most of them do stand on their own with updated test > code (one of them fails tests). Yo

Re: Request for Review: Cursor & Icon patches

2009-07-25 Thread Daniel Santos
hes in both the incremental form in addition to a single bulk patch. I guess it doesn't matter too much since you can do that pretty easily in git anyway. Thank you for the responses. Daniel --- On Sat, 7/25/09, Frédéric Delanoy wrote: > From: Frédéric Delanoy > Subject: Re: Reques

Re: Request for Review: Cursor & Icon patches

2009-07-25 Thread Frédéric Delanoy
On 07/25/2009 02:06 PM, Roderick Colenbrander wrote: > On Sat, Jul 25, 2009 at 8:04 AM, lats wrote: >> On 25/07/09 12:46, Daniel Santos wrote: >> >>> I finished the actual code about 3 weeks ago, but it's been a lot of work for me to split it out into smaller pieces, especially being new

Re: Request for Review: Cursor & Icon patches

2009-07-25 Thread Roderick Colenbrander
On Sat, Jul 25, 2009 at 8:04 AM, lats wrote: > On 25/07/09 12:46, Daniel Santos wrote: > >> >> I finished the actual code about 3 weeks ago, >>> >>> but it's been a lot of work for me to split it out into >>> smaller pieces, especially being new to git. > > The intention is that is that you build a

Re: Request for Review: Cursor & Icon patches

2009-07-25 Thread lats
On 25/07/09 12:46, Daniel Santos wrote: I finished the actual code about 3 weeks ago, but it's been a lot of work for me to split it out into smaller pieces, especially being new to git. The intention is that is that you build and test smaller chunks, hence the term "commit often". It cert

Request for Review: Cursor & Icon patches

2009-07-24 Thread Daniel Santos
I haven't heard anything, so if anybody can find the time I would greatly appreciate it. Thanks, Daniel --- On Thu, 7/23/09, Daniel Santos wrote: > From: Daniel Santos > Subject: Cursor & Icon patches > To: "wine-devel" > Date: Thursday, July 23, 2009, 1:59 AM > Hello everybody! > > Attach