Re: Remove heap.h

2005-01-01 Thread Jon Griffiths
Hi, >>+docA.lpszDocName = WtoA( doc->lpszDocName ); >>+docA.lpszOutput = WtoA( doc->lpszOutput ); >>+docA.lpszDatatype = WtoA( doc->lpszDatatype; >> >Isn't there a missing parenthesis? There sure is, I must have deleted it while removing the cruft from the diff (since it compiles fine

Re: Remove heap.h

2005-01-01 Thread Dimitrie O. Paun
On Sat, Jan 01, 2005 at 07:47:11AM -0800, Jon Griffiths wrote: > >Because in 99.99% of cases you don't want to convert from W->A. > >If all our functions are Unicode, a W->A conversion is a warning > >sign, and for sure you wouldn't want to encourage people to do > >so by making it any easier. > >

Re: Remove heap.h

2004-12-30 Thread Filip Navara
Jon Griffiths wrote: +docA.lpszDocName = WtoA( doc->lpszDocName ); +docA.lpszOutput = WtoA( doc->lpszOutput ); +docA.lpszDatatype = WtoA( doc->lpszDatatype; Isn't there a missing parenthesis?

Re: Remove heap.h

2004-12-30 Thread Dimitrie O. Paun
On Thu, Dec 30, 2004 at 09:08:58PM +, Mike Hearn wrote: > I don't really understand why we can't make this an inline or something, > it seems that it's a lot more convenient than the direct win32 > equivalents. Making it an inline would achieve the same effect as simply > replacing each usage m

Re: Remove heap.h

2004-12-30 Thread Mike Hearn
On Thu, 30 Dec 2004 15:41:06 -0500, Dimitrie O. Paun wrote: > To be honest, I'm not too happy with this patch, HEAP_strdupWtoA > was a good marker for code that needed fixing, this patch just > makes those places harder to find. I don't really understand why we can't make this an inline or somethi

Re: Remove heap.h

2004-12-30 Thread Dimitrie O. Paun
On Thu, Dec 30, 2004 at 07:57:31AM -0800, Jon Griffiths wrote: > Hi, > > After applying, include/heap.h can be removed from cvs. To be honest, I'm not too happy with this patch, HEAP_strdupWtoA was a good marker for code that needed fixing, this patch just makes those places harder to find. --