Re: [PATCH] regedit: fixed a fclose(stdin) issue (Coverity)

2012-11-19 Thread Frédéric Delanoy
the stdin case. > > Ciao, Marcus > --- > programs/regedit/regedit.c |1 + > 1 Datei geändert, 1 Zeile hinzugefügt(+) > > diff --git a/programs/regedit/regedit.c b/programs/regedit/regedit.c > index acff701..b6f74ee 100644 > --- a/programs/regedit/regedit.c &g

Re: [PATCH] regedit: err() on printing

2012-10-12 Thread Charles Davis
On Oct 12, 2012, at 6:12 AM, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > >> +ERR("printing is not yet implemented.\n"); > > Printing a FIXME seems more appropriate. Also, aren't programs supposed to use the prefixed calls (e.g. WINE_FIXME() instead of FIXME())? Chip

Re: [PATCH] regedit: err() on printing

2012-10-12 Thread Dmitry Timoshkov
Marcus Meissner wrote: > +ERR("printing is not yet implemented.\n"); Printing a FIXME seems more appropriate. -- Dmitry.

Re: Testing regedit

2012-05-24 Thread Frédéric Delanoy
On Thu, May 24, 2012 at 8:47 AM, Daniel Jelinski wrote: > 2012/5/24 Austin English : >> On Wed, May 23, 2012 at 12:24 PM, Daniel Jelinski >> wrote: >>> Hello, >>> I just noticed that wine's regedit has a few interesting bugs that >>> appear when ru

Re: Testing regedit

2012-05-23 Thread Daniel Jelinski
2012/5/24 Austin English : > On Wed, May 23, 2012 at 12:24 PM, Daniel Jelinski > wrote: >> Hello, >> I just noticed that wine's regedit has a few interesting bugs that >> appear when running with native comctl32. Can I/should I file them in >> the bugzilla? >

Re: Testing regedit

2012-05-23 Thread Austin English
On Wed, May 23, 2012 at 12:24 PM, Daniel Jelinski wrote: > Hello, > I just noticed that wine's regedit has a few interesting bugs that > appear when running with native comctl32. Can I/should I file them in > the bugzilla? > > Regards, > Daniel What sort of bugs? In ge

Testing regedit

2012-05-23 Thread Daniel Jelinski
Hello, I just noticed that wine's regedit has a few interesting bugs that appear when running with native comctl32. Can I/should I file them in the bugzilla? Regards, Daniel

Re: regedit: Remove the printing code

2011-09-02 Thread Frédéric Delanoy
2011/9/1 André Hentschel : > It does nothing (except confusing) > beside that i doubt someone wants to print registry hives That's not a reason IMHO. What should be done is fix the printing so it works like on windows (or put an error box: "not yet implemented", or similar)

Re: regedit: Remove the printing code

2011-09-02 Thread Jerome Leclanche
To be fair, that feature is available on Windows. 2011/9/1 André Hentschel : > It does nothing (except confusing) > beside that i doubt someone wants to print registry hives > > --- >  programs/regedit/En.rc      |    1 - >  programs/regedit

Re: 78266: Subject: regedit: Remove the printing code

2011-09-01 Thread buildbot
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/206 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

Re: regedit: adding confirmation message before importing from file

2011-08-19 Thread Nowres Rafid
On Wed, 2011-08-17 at 08:19 -0700, Dan Kegel wrote: > On Wed, Aug 17, 2011 at 8:17 AM, Dan Kegel wrote: > > Hi Nowres, > > did you run the regedit tests, > > cd programs/regedit/tests > > make test > > after that change? Here it fails with > >

Re: regedit: adding confirmation message before importing from file

2011-08-17 Thread Nowres Rafid
On 17/08/2011 15:19, Dan Kegel wrote: On Wed, Aug 17, 2011 at 8:17 AM, Dan Kegel wrote: Hi Nowres, did you run the regedit tests, cd programs/regedit/tests make test after that change? Here it fails with regedit.c:384: Test failed: regedit not available, skipping regedit tests ( log

Re: regedit: adding confirmation message before importing from file

2011-08-17 Thread Dan Kegel
On Wed, Aug 17, 2011 at 8:17 AM, Dan Kegel wrote: > Hi Nowres, > did you run the regedit tests, >   cd programs/regedit/tests >   make test > after that change?  Here it fails with >  regedit.c:384: Test failed: regedit not available, skipping regedit tests > ( log at http

re: regedit: adding confirmation message before importing from file

2011-08-17 Thread Dan Kegel
Hi Nowres, did you run the regedit tests, cd programs/regedit/tests make test after that change? Here it fails with regedit.c:384: Test failed: regedit not available, skipping regedit tests ( log at http://buildbot.kegel.com/builders/runtests/builds/2 ) You might need to fully implement

Re: regedit: adding confirmation message before importing from file

2011-08-17 Thread Andrew Eikum
On Wed, Aug 17, 2011 at 12:24:18PM +, Nowres Rafid wrote: > -reg_file = fopen(realname, "r"); > + > + reg_file = fopen(realname, "r"); The file uses spaces for indenting. Please be consistent and don't use tabs. This is true elsewhere, to

New winetricks-alpha 20110222-alpha: new verbs d3dx11_43, dragonage2_demo, regedit, shell, taskmgr, winecfg

2011-02-22 Thread Dan Kegel
Right, it's only been a couple days, but here's a new winetricks already. This release adds dragonage2_demo (released earlier today -- hey, we're starting to keep up!) as well as the handy verbs d3dx11_43, regedit, shell, taskmgr, and winecfg, and a few bugfixes. Downl

Re: regedit: add a manpage

2010-11-13 Thread François Wendling
On Fri, Nov 12, 2010 at 07:52:24PM +, Austin English wrote: > On Fri, Nov 12, 2...@7:29 PM, Alexandre Julliard wrote: > > Austin English writes: > > > >> I wasn't worried about the patches being under my name. I'll email the > >> author and ask him to submit them, but I'm not holding my breat

Re: regedit: add a manpage

2010-11-12 Thread Austin English
On Fri, Nov 12, 2010 at 7:29 PM, Alexandre Julliard wrote: > Austin English writes: > >> I wasn't worried about the patches being under my name. I'll email the >> author and ask him to submit them, but I'm not holding my breath, >> since the Debian wine package is very out of date and inactive. I

Re: regedit: add a manpage

2010-11-12 Thread Alexandre Julliard
Austin English writes: > I wasn't worried about the patches being under my name. I'll email the > author and ask him to submit them, but I'm not holding my breath, > since the Debian wine package is very out of date and inactive. If I > don't receive a response in a week or so, would it be okay t

Re: regedit: add a manpage

2010-11-12 Thread Austin English
On Fri, Nov 12, 2010 at 11:10 AM, Alexandre Julliard wrote: > Austin English writes: > >> While looking at the Debian Wine sources, I found they have manpages >> for several of our bulitin programs :-) > > Then you should ask them to submit patches. You can't just grab the > manpages and submit u

Re: regedit: add a manpage

2010-11-12 Thread Alexandre Julliard
Austin English writes: > While looking at the Debian Wine sources, I found they have manpages > for several of our bulitin programs :-) Then you should ask them to submit patches. You can't just grab the manpages and submit under your name. -- Alexandre Julliard julli...@winehq.org

Re: regedit: Added Hebrew translation

2010-08-03 Thread Charles Davis
On 8/3/10 4:58 AM, Yaron Shahrabani wrote: > How can I compile a single RC file? After configuring Wine, go to the directory containing the RC file and type in a Terminal: make .res where is the part of the filename before the '.rc' extension. So if you wanted to compile only He.r

Re: regedit: Added Hebrew translation

2010-08-03 Thread Yaron Shahrabani
How can I compile a single RC file? Yaron Shahrabani On Tue, Aug 3, 2010 at 12:39 PM, Alexandre Julliard wrote: > Yaron Shahrabani writes: > > > Hope everything is cool this time :) > > +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 > > +STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_VISIBLE |

Re: regedit: Added Hebrew translation

2010-08-03 Thread Alexandre Julliard
Yaron Shahrabani writes: > Hope everything is cool this time :) > +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 > +STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | > +WS_BORDER > +WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" That's not valid syntax. Please try to compile

Re: regedit: use binary mode when doing file import/export (try 2)

2010-06-08 Thread Alexandre Julliard
Damjan Jovanovic writes: > Changelog: > * regedit: use binary mode when doing file import/export I don't think it will work properly for output. -- Alexandre Julliard julli...@winehq.org

Re: regedit: Implement open last key at startup [try 2]

2009-07-02 Thread Michael Karcher
Am Donnerstag, den 02.07.2009, 09:02 +0200 schrieb Paul Vriens: > There is no need for the RegCloseKey as you are opening a predefined one. Are you sure? He opens "HKCU\Software\Microsoft\Windows\CurrentVersion \Applets\Regedit" Regards, Michael Karcher signature.asc Description:

Re: regedit: Implement open last key at startup [try 3]

2009-07-02 Thread Paul Vriens
ke HKEY_CURRENT_USER, you do have to close HKCU\Software\Microsoft\Windows \CurrentVersion\Applets\Regedit. So, does the RegCloseKey only have to be done in the set/create case? I mean while reading MSDN (yeah, I know) it states: "If the key is not one of the predefined registry keys, call

Re: regedit: Implement open last key at startup [try 3]

2009-07-02 Thread Paul Vriens
USER, you do have to close HKCU\Software\Microsoft\Windows \CurrentVersion\Applets\Regedit. So, does the RegCloseKey only have to be done in the set/create case? I mean while reading MSDN (yeah, I know) it states: "If the key is not one of the predefined registry keys, call the RegCloseKe

Re: regedit: Implement open last key at startup [try 3]

2009-07-02 Thread Michael Karcher
HKCU\Software\Microsoft\Windows \CurrentVersion\Applets\Regedit. Regards, Michael Karcher

Re: regedit: Implement open last key at startup [try 2]

2009-07-02 Thread Paul Vriens
Vladimir Pankratov wrote: Hello. Open last key at startup. Changed files: regedit/childwin.c Thanks. Hi Vladimir, Please use a constant instead of hardcoded 260 as suggested by Andre'. You also should be usin

Re: regedit: Open last key at startup

2009-07-01 Thread André Hentschel
Alexandre Julliard schrieb: Vladimir Pankratov writes: Hi all. Open last key at startup. Don't resend the same patch every single day, that will only get you ignored. Instead, spend some more time looking at your patch and I'm sure you can figure out why it's not going to work. Hi Vladi

Re: regedit: Open last key at startup

2009-07-01 Thread Alexandre Julliard
Vladimir Pankratov writes: > Hi all. > > Open last key at startup. Don't resend the same patch every single day, that will only get you ignored. Instead, spend some more time looking at your patch and I'm sure you can figure out why it's not going to work. -- Alexandre Julliard julli...@wineh

Re: regedit: remember settings state

2009-05-11 Thread Dmitry Timoshkov
"André Hentschel" wrote: LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) { +HKEY hKey; +LPWSTR lpKeyPath; switch (message) { case WM_CREATE: Indentation is weird. And an empty line after variables won't hurt. -- Dmitry.

Re: [PATCH] regedit: Pass VK_DELETE messages to edit controls. (try 2)

2008-10-08 Thread Alexandre Julliard
"Lei Zhang" <[EMAIL PROTECTED]> writes: > In regedit, while renaming registry keys / values, the delete key does > not work. This should fix it. > > This version increased the len variable by 1, so comparing "Edit" to > "EditX" will fail. Test

Re: regedit 1/2: Use unicode strings when updating listview

2008-08-27 Thread Alexander Nicolaysen Sørnes
På Torsdag 28 august 2008 , 00:29:03 skrev Alexander Nicolaysen Sørnes: > Should be applied after Juan's regedit patch > > > Alexander N. Sørnes Sorry, mean't Lei's. No offence intended. :D

Re: regedit: Fix concat handling for ANSI files (try2)

2008-08-27 Thread Alexandre Julliard
Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes: > +if(c == EOF) > fprintf(stderr,"%s: ERROR - invalid continuation.\n", > getAppName()); > + > +*s = c; > +s++; It's better, but I don't think

Re: regedit: Fix concat handling for ANSI files

2008-08-26 Thread Alexandre Julliard
Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes: > +do > +{ > +*s = fgetc(in); > +} while(*s == ' ' || *s == '\t'); > + > +if(*s == EOF) > fprintf(stderr,"%s: ERROR - invalid continuatio

Re: regedit 1/2: Convert key creation to unicode

2008-08-22 Thread Alexander Nicolaysen Sørnes
> Alexander Nicolaysen Sørnes wrote: > > regedit 1/2: Convert key creation to unicode > > Why do you add extra TCHARs then? You replace one or two with WCHAR and > then add a lot more TCHARs. Some of them are removed by patch 2/2, others were added to consistently store th

Re: regedit 1/2: Convert key creation to unicode

2008-08-22 Thread Michael Stefaniuc
Alexander Nicolaysen Sørnes wrote: > regedit 1/2: Convert key creation to unicode Why do you add extra TCHARs then? You replace one or two with WCHAR and then add a lot more TCHARs. > From 2f56e158d55011ac4294d113f844c32fb998a2c2 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Alexander=20N

Re: Alexander Nicolaysen Sørnes : regedit: Convert printing&help to unicode.

2008-08-20 Thread Alexander Nicolaysen Sørnes
462790338677dac3bfb394df8f4da020 > >>> URL: > >>> http://source.winehq.org/git/wine.git/?a=commit;h=5cb8bccf462790338677d > >>>ac 3bfb394df8f4da020 > >>> > >>> Author: Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> > >>>

Re: Alexander Nicolaysen Sørnes : regedit: Con vert printing&help to unicode.

2008-08-20 Thread Eric Pouech
>>> http://source.winehq.org/git/wine.git/?a=commit;h=5cb8bccf462790338677dac >>> 3bfb394df8f4da020 >>> >>> Author: Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> >>> Date: Sun Aug 10 12:43:06 2008 +0200 >>> >>> regedit: Conve

Re: Alexander Nicolaysen Sørnes : regedit: Convert printing&help to unicode.

2008-08-20 Thread Michael Karcher
Am Mittwoch, den 20.08.2008, 19:55 +0200 schrieb Alexander Nicolaysen Sørnes: > > > +const WCHAR empty = 0; > > > +PrintRegistryHive(hWnd, empty); > > to send an empty string? It is. This sends a NULL pointer (empty is 0, converted to a pointer is a NULL pointer). You mean "&empty

Re: Alexander Nicolaysen Sørnes : regedit: Convert printing&help to unicode.

2008-08-20 Thread Alexander Nicolaysen Sørnes
790338677dac > >3bfb394df8f4da020 > > > > Author: Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> > > Date: Sun Aug 10 12:43:06 2008 +0200 > > > > regedit: Convert printing&help to unicode. > > > > --- > > > > programs/regedit/framewnd.c |

Re: Alexander Nicolaysen Sørnes : regedit: Con vert printing&help to unicode.

2008-08-20 Thread Eric Pouech
D]> > Date: Sun Aug 10 12:43:06 2008 +0200 > > regedit: Convert printing&help to unicode. > > --- > > programs/regedit/framewnd.c | 25 + > 1 files changed, 17 insertions(+), 8 deletions(-) > > @@ -671,8 +671,11 @@ static BOOL _CmdWnd

Re: regedit: Implement deleting multiple values (resend)

2008-07-10 Thread John Klehm
On Thu, Jul 10, 2008 at 8:20 AM, Andre Wisplinghoff <[EMAIL PROTECTED]> wrote: > Changelog: > Regedit: Implement deleting multiple values > > Changes from first send as suggested @ wine-devel: > - Use standard MessageBox instead of making the messagebox function from > ed

Feedback for "Regedit: Implement deleting multiple values"

2008-07-10 Thread Andre Wisplinghoff
Hallo, thanks for your help. I just resend my patch, with these issues considered. The standard MessageBox function is now used. The localized message is read in framewnd.c and errors treated the same way as it was with the messagebox function in edit.c. Best Regards - Andre Wisplinghoff

Re: regedit: 3/7 Convert the rest of setValue to unicode

2008-07-10 Thread Alexandre Julliard
Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes: > @@ -185,13 +199,16 @@ static DWORD getDataType(LPSTR *lpValue, DWORD* > parse_type) > *lpValue+=ptr->len; > if (type == -1) { > char* end; > +char* buf = HeapAlloc(GetProcessHeap(), 0, > (lstrlen

Re: Feedback for "Regedit: Implement deleting multiple values"

2008-07-09 Thread Alexander Nicolaysen Sørnes
På Onsdag 09 juli 2008 , 13:36:19 skrev Andre Wisplinghoff: > Hallo, > > my patch [1] wasn't applied. Can anyone give me a hint what wasn't OK with > it? > Thanks for your time. > You could use standard MessageBox() instead of making messagebox() non-static. Alexander N. Sørnes > Best Regards >

Re: Feedback for "Regedit: Implement deleting multiple values"

2008-07-09 Thread John Klehm
On Wed, Jul 9, 2008 at 6:36 AM, Andre Wisplinghoff <[EMAIL PROTECTED]> wrote: > Hallo, > > my patch [1] wasn't applied. Can anyone give me a hint what wasn't OK with > it? > Thanks for your time. > Couple non code things: 1) Real name in the patch. 2) No html email --John Klehm

Feedback for "Regedit: Implement deleting multiple values"

2008-07-09 Thread Andre Wisplinghoff
Hallo, my patch [1] wasn't applied. Can anyone give me a hint what wasn't OK with it? Thanks for your time. Best Regards - Andre Wisplinghoff [1] http://www.winehq.org/pipermail/wine-patches/2008-July/057227.html

Re: regedit: stdin is not seekable so do not try to seek the input file if it is not seekable

2008-03-14 Thread Alexandre Julliard
Aric Stewart <[EMAIL PROTECTED]> writes: > True, through I did not add the code that was doing the seeking so i > tried to not be too intrusive. > > Should I rework the way we do the line processing to be able to do > this then? Yes please. -- Alexandre Julliard [EMAIL PROTECTED]

Re: regedit: stdin is not seekable so do not try to seek the input file if it is not seekable

2008-03-14 Thread Aric Stewart
True, through I did not add the code that was doing the seeking so i tried to not be too intrusive. Should I rework the way we do the line processing to be able to do this then? -aric Alexandre Julliard wrote: > Aric Stewart <[EMAIL PROTECTED]> writes: > >> --- >> pr

Re: regedit: stdin is not seekable so do not try to seek the input file if it is not seekable

2008-03-14 Thread Alexandre Julliard
Aric Stewart <[EMAIL PROTECTED]> writes: > --- > programs/regedit/regedit.c |2 +- > programs/regedit/regproc.c | 19 +++---- > programs/regedit/regproc.h |2 +- > 3 files changed, 13 insertions(+), 10 deletions(-) We shouldn't need to seek at

Re: regedit: fixed a memory leak in listview.c (found by Smatch).

2007-09-03 Thread Dmitry Timoshkov
"Lionel_Debroux" <[EMAIL PROTECTED]> wrote: diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c index 0e4b52b..8b58eec 100644 --- a/programs/regedit/listview.c +++ b/programs/regedit/listview.c @@ -61,7 +61,10 @@ static LPTSTR get_item_text(HWND hwndLV, int i

Re: [programs/regedit] Fix command line processing for /? patch

2007-04-27 Thread Tom Spear
f the usage statement and exit(1); or should we >> > > print both the usage, and the error for the invalid switch. >> > > >> > > Unfortunately I don't have a copy of win98's regedit, and winxp's >> > > regedit does not accept command line switches (I have

Re: [programs/regedit] Fix command line processing for /? patch

2007-04-27 Thread Carl-Daniel Hailfinger
OTECTED]> wrote: >> > > > You don't want to do that, even if you print usage, an invalid >> switch >> > > > needs to cause an error. >> > > So should we fprintf the usage statement and exit(1); or should we >> > > print both the usage

Re: [programs/regedit] Fix command line processing for /? patch

2007-04-27 Thread Tom Spear
hat, even if you print usage, an invalid switch > > > needs to cause an error. > > So should we fprintf the usage statement and exit(1); or should we > > print both the usage, and the error for the invalid switch. > > > > Unfortunately I don't have a copy of win98's

Re: [programs/regedit] Fix command line processing for /? patch

2007-04-27 Thread Tom Spear
rror. > So should we fprintf the usage statement and exit(1); or should we > print both the usage, and the error for the invalid switch. > > Unfortunately I don't have a copy of win98's regedit, and winxp's > regedit does not accept command line switches (I have tri

Re: [programs/regedit] Fix command line processing for /? patch

2007-04-27 Thread Tom Spear
we print both the usage, and the error for the invalid switch. Unfortunately I don't have a copy of win98's regedit, and winxp's regedit does not accept command line switches (I have tried), so I can't check (easily) how the native regedit that ours is supposed to be command-line c

Re: [programs/regedit] Fix command line processing for /? patch

2007-04-27 Thread Tom Spear
fortunately I don't have a copy of win98's regedit, and winxp's regedit does not accept command line switches (I have tried), so I can't check (easily) how the native regedit that ours is supposed to be command-line compatible with, does it. -- Thanks Tom Check out this new 3

Re: [programs/regedit] Fix command line processing for /? patch

2007-04-27 Thread Alexandre Julliard
"Tom Spear" <[EMAIL PROTECTED]> writes: > --- programs/regedit/regedit.c.old2007-04-25 11:53:24.0 -0500 > +++ programs/regedit/regedit.c2007-04-25 11:57:30.0 -0500 > @@ -104,13 +104,10 @@ > case 'E': >

Re: [1/8] regedit: Remove the _stscanf function dependency.

2007-04-07 Thread Byeong-Sik Jeon
Alexandre Julliard wrote: > Byeong-Sik Jeon <[EMAIL PROTECTED]> writes: > > > _stscanf depends tchar.h > > > > Changelog: > > Remove the _stscanf function dependency. > > You are going about this the wrong way. What you should do is convert > the code to use explicit Unicode functions. Removi

Re: [1/8] regedit: Remove the _stscanf function dependency.

2007-04-07 Thread Alexandre Julliard
Byeong-Sik Jeon <[EMAIL PROTECTED]> writes: > _stscanf depends tchar.h > > Changelog: > Remove the _stscanf function dependency. You are going about this the wrong way. What you should do is convert the code to use explicit Unicode functions. Removing TCHAR and the like will then be an automa

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Robert Shearman wrote: > Byeong-Sik Jeon wrote: > > Hi, > > > > MS-Windows's RegQueryKeyInfo function test result: > > > > 1. MSDN means TCHARS when it says 'character' for this function. > > ==> No. > > 2. why RegQueryInfoKey is returning a number that is too small > > ==> No. Currently Wi

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Robert Shearman wrote: > Byeong-Sik Jeon wrote: > > Hi, > > > > MS-Windows's RegQueryKeyInfo function test result: > > > > 1. MSDN means TCHARS when it says 'character' for this function. > > ==> No. > > 2. why RegQueryInfoKey is returning a number that is too small > > ==> No. Currently Wi

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Bill Medland wrote: > I confess that I have not tested this. I think it is sufficiently > counterintuitive that it would be useful if you could submit a test that > would demonstrate it, e.g. put a non-SBCS string into the registry in > Unicode, query and get it back out, demonstrating that the si

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Bill Medland
On Thu, 2007-05-04 at 12:03 +0900, Byeong-Sik Jeon wrote: > Hi, > > MS-Windows's RegQueryKeyInfo function test result: > > 1. MSDN means TCHARS when it says 'character' for this function. > ==> No. > 2. why RegQueryInfoKey is returning a number that is too small > ==> No. Currently Wine's

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Alexandre Julliard wrote: > Byeong-Sik Jeon <[EMAIL PROTECTED]> writes: > > > another soultion: > > * we can change the "IDS_NEWKEY, IDS_NEWVALUE" of resource file. > > * define the UNICODE > > but these sulution don't fix the regedit's

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Robert Shearman
Byeong-Sik Jeon wrote: Hi, MS-Windows's RegQueryKeyInfo function test result: 1. MSDN means TCHARS when it says 'character' for this function. ==> No. 2. why RegQueryInfoKey is returning a number that is too small ==> No. Currently Wine's RegQueryInfoKey set the right values. Sorry

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Alexandre Julliard
Byeong-Sik Jeon <[EMAIL PROTECTED]> writes: > another soultion: > * we can change the "IDS_NEWKEY, IDS_NEWVALUE" of resource file. > * define the UNICODE > but these sulution don't fix the regedit's bug. just bug hide... What we should do for regedit, an

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Hi, MS-Windows's RegQueryKeyInfo function test result: 1. MSDN means TCHARS when it says 'character' for this function. ==> No. 2. why RegQueryInfoKey is returning a number that is too small ==> No. Currently Wine's RegQueryInfoKey set the right values. Thank you.

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
t; > UTF-8 it could require even more than two. > > > > > example: > > > string "새 값 #1" has 6 characters. It is max_val_name_len. > > > w/ UNICODE, this string is 6 * sizeof(WCHAR) bytes. > > > w/o UNICODE, this string is 8 bytes. > &g

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
"새 값 #1" has 6 characters. It is max_val_name_len. > > w/ UNICODE, this string is 6 * sizeof(WCHAR) bytes. > > w/o UNICODE, this string is 8 bytes. > > 8 == space(1) * 2 + #(1) + 1(1) + 새(2) + 값(2) > > > > Currently regedit compiled without UNICODE.

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Bill Medland
On Thu, 2007-05-04 at 06:17 +0900, Byeong-Sik Jeon wrote: > Bill Medland wrote: > > On Thu, 2007-05-04 at 02:18 +0900, Byeong-Sik Jeon wrote: > > > Hi, > > > > > > Currently regedit is not defined "UNICODE". > > > > > > The

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Bill Medland wrote: > On Thu, 2007-05-04 at 02:18 +0900, Byeong-Sik Jeon wrote: > > Hi, > > > > Currently regedit is not defined "UNICODE". > > > > The point are "max_val_name_len", "valName", "valNameLen". > > Not ma

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Bill Medland wrote: > On Thu, 2007-05-04 at 02:18 +0900, Byeong-Sik Jeon wrote: > > Hi, > > > > Currently regedit is not defined "UNICODE". > > > > The point are "max_val_name_len", "valName", "valNameLen". > > Not ma

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Bill Medland
On Thu, 2007-05-04 at 02:18 +0900, Byeong-Sik Jeon wrote: > Hi, > > Currently regedit is not defined "UNICODE". > > The point are "max_val_name_len", "valName", "valNameLen". > Not max_val_size, valSize. > > RegQueryInfoKey set th

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Hi, Currently regedit is not defined "UNICODE". The point are "max_val_name_len", "valName", "valNameLen". Not max_val_size, valSize. RegQueryInfoKey set the "max_val_name_len" to the size of the longest value name, in characters. This val

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Detlef Riekenberg
On Mi, 2007-04-04 at 10:36 +0900, Byeong-Sik Jeon wrote: > > +/* convert from WCHAR size to maximum required TCHAR size */ > +max_val_name_len *= sizeof(WCHAR) / sizeof(TCHAR); > + > valName = HeapAlloc(GetProcessHeap(), 0, max_val_name_len * > sizeof(TCHAR)); > valBuf = HeapAll

Re: [1/2] regedit: Support the REG_MULTI_SZ.

2007-03-30 Thread Byeong-Sik Jeon
oops!!! you are right. Thank you. Juan Lang wrote: > Hi Byeong-Sik, > > +lRet = RegSetValueEx(hKey, valueName, 0, type, > (LPBYTE)stringValueData, j); > > I think that should be j * sizeof(TCHAR), yes? > --Juan

Re: [1/2] regedit: Support the REG_MULTI_SZ.

2007-03-30 Thread Juan Lang
Hi Byeong-Sik, +lRet = RegSetValueEx(hKey, valueName, 0, type, (LPBYTE)stringValueData, j); I think that should be j * sizeof(TCHAR), yes? --Juan Food fight? Enjoy some healthy debate in the Yaho

Re: Regedit output to STDOUT / force registry files sync

2007-03-22 Thread Vit Hrachovy
On Wed, Mar 21, 2007 at 11:38:03PM +0100, Detlef Riekenberg wrote: > On Di, 2007-03-20 at 21:12 +0100, Vit Hrachovy wrote: > > > Hi Bill, > > that's not the case I'm searching for. I'm aware that regedit can export > > into files. I simply want registry

Re: Regedit output to STDOUT / force registry files sync

2007-03-21 Thread Detlef Riekenberg
On Di, 2007-03-20 at 21:12 +0100, Vit Hrachovy wrote: > Hi Bill, > that's not the case I'm searching for. I'm aware that regedit can export > into files. I simply want registry export to STDOUT nothing else. Did you test reg.exe / regini.exe ? > I'm going to

Re: Regedit output to STDOUT / force registry files sync

2007-03-21 Thread Vit Hrachovy
Lei Zhang wrote: Believe it or not, there are UNIXes without /dev/stderr and /dev/stdout. Having regedit option to flush its output to STDOUT (and to get its input from STDIN) would be very helpful - and in case of STDOUT output very easy to implement. Regards Vit Hrachovy Sure, but Unices

Re: Regedit output to STDOUT / force registry files sync

2007-03-20 Thread Lei Zhang
On 3/20/07, Vit Hrachovy <[EMAIL PROTECTED]> wrote: Bill Medland wrote: > On Tue, 2007-20-03 at 21:12 +0100, Vit Hrachovy wrote: >> Bill Medland wrote: >> >>>> b) Enhance regedit to be able to output to STDOUT. By default registry >>>> search

Re: Regedit output to STDOUT / force registry files sync

2007-03-20 Thread Vit Hrachovy
Bill Medland wrote: On Tue, 2007-20-03 at 21:12 +0100, Vit Hrachovy wrote: Bill Medland wrote: b) Enhance regedit to be able to output to STDOUT. By default registry search output is done to a specified file. It can be redirected to STDERR, though. (tested on 0.9.29, 0.9.33) c) Use the

Re: Regedit output to STDOUT / force registry files sync

2007-03-20 Thread Bill Medland
On Tue, 2007-20-03 at 21:12 +0100, Vit Hrachovy wrote: > Bill Medland wrote: > > >> b) Enhance regedit to be able to output to STDOUT. By default registry > >> search output is done to a specified file. It can be redirected to > >> STDERR, though. (tested on 0.

Re: Regedit output to STDOUT / force registry files sync

2007-03-20 Thread Vit Hrachovy
Bill Medland wrote: b) Enhance regedit to be able to output to STDOUT. By default registry search output is done to a specified file. It can be redirected to STDERR, though. (tested on 0.9.29, 0.9.33) c) Use the shell wine regedit -e /tmp/$$.reg && cat /tmp/$$.reg && rm

Re: Regedit output to STDOUT / force registry files sync

2007-03-20 Thread Bill Medland
console --backend=user cmd > 2. During session, insert some new registry key > regedit new-entry.reg > 3. Try to access the new registry entry from bash > cat ~/.wine/system.reg |grep AutoHotkey > (fails) > 4. Close WINE s

Re: Regedit output to STDOUT / force registry files sync

2007-03-20 Thread Lei Zhang
WINE session, i.e. without restarting WINE. > > > >Test case description: > >1. Open WINE session > >wineconsole --backend=user cmd > > 2. During session, insert some new registry key > >regedit

Re: Regedit output to STDOUT / force registry files sync

2007-03-19 Thread Vit Hrachovy
gt;Test case description: > >1. Open WINE session > >wineconsole --backend=user cmd > >2. During session, insert some new registry key > >regedit new-entry.reg > >3. Try to access the new registry

Re: Regedit output to STDOUT / force registry files sync

2007-03-19 Thread Lei Zhang
d 2. During session, insert some new registry key regedit new-entry.reg 3. Try to access the new registry entry from bash cat ~/.wine/system.reg |grep AutoHotkey (fails) Accessing the Wine registry directly is probably not the right way to

Regedit output to STDOUT / force registry files sync

2007-03-19 Thread Vit Hrachovy
y key regedit new-entry.reg 3. Try to access the new registry entry from bash cat ~/.wine/system.reg |grep AutoHotkey (fails) 4. Close WINE session I've found there was at times an option to save registry periodically, but this can'

Re: regedit: Allow importing UCS-2 and UTF-8 files created by Windows' regedit v5

2006-10-12 Thread Detlef Riekenberg
On Do, 2006-10-12 at 17:30 +0300, Paul Chitescu wrote: > +/* Attempt to guess the encoding from the first several > bytes */ > + > +/* Extremely crude routine to convert to 8-bit */ Thanks for working on this Feature. As already mentioned, UNICODE is the better way. (You c

Re: regedit: Allow importing UCS-2 and UTF-8 files created by Windows'regedit v5

2006-10-12 Thread Dmitry Timoshkov
"Paul Chitescu" <[EMAIL PROTECTED]> wrote: +/* Attempt to guess the encoding from the first several bytes */ +if (encoding < 0) { +if (line [0] == '\377' && line [1] == '\376') { +encoding = 2; /* FF FE=> UCS-2 little endian */ +

Re: regedit: Allow importing UCS-2 and UTF-8 files created by Windows' regedit v5

2006-10-12 Thread Robert Shearman
Paul Chitescu wrote: Changelog: regedit: Allow importing UCS-2 and UTF-8 files created by Windows' regedit v5. The code tries to detect the encoding from the first read bytes. UTF-8 is not modified while UCS-2 is converted by keeping only the lower byte. The code that you have add

Re: regedit: also refresh the listview

2006-09-06 Thread Jan Zerebecki
On Wed, Sep 06, 2006 at 07:14:08AM -0600, Vitaliy Margolen wrote: > Jan Zerebecki wrote: > > case ID_VIEW_REFRESH: > > RefreshTreeView(g_pChildWnd->hTreeWnd); > > -/*RefreshListView(g_pChildWnd->hListWnd, hKeyRoot, keyPath, NULL); > > */ > > +RefreshListView(g_pChildW

Re: regedit: also refresh the listview

2006-09-06 Thread Vitaliy Margolen
Jan Zerebecki wrote: > case ID_VIEW_REFRESH: > RefreshTreeView(g_pChildWnd->hTreeWnd); > -/*RefreshListView(g_pChildWnd->hListWnd, hKeyRoot, keyPath, NULL); */ > +RefreshListView(g_pChildWnd->hListWnd, hKeyRoot, keyPath, NULL); > break; There was a reason why

Re: regedit[1/2]: remove custom filter from open/save dialogs

2006-08-23 Thread Alexandre Julliard
Mikołaj Zalewski <[EMAIL PROTECTED]> writes: > --- framewnd_orig.c 2006-08-10 15:15:12.0 +0200 > +++ framewnd.c2006-08-22 22:10:05.0 +0200 Please generate diffs from the top-level directory. -- Alexandre Julliard [EMAIL PROTECTED]

Re: regedit: Write-strings warnings fix and remove superfluous casts (Resend)

2006-08-16 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > Please tell me what is wrong with this patch. Thank you. It's causing warnings: gcc -c -I. -I. -I../../include -I../../include -I../../include/msvcrt -DNO_LIBWINE_PORT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-s

  1   2   >