Mike Hearn wrote:
On Sat, 27 Nov 2004 20:37:21 +, Aneurin Price wrote:
Thanks for that; it's just the kind of comment I was looking for.
It wasn't a full patch as I wasn't planning to get it applied, and a
number of points were where I copied code from what was there already
:), but you even
On Sat, 27 Nov 2004 20:37:21 +, Aneurin Price wrote:
> So, I've had a go over this all, and here is a new version. Is it a step
> in the right direction? I still don't really know what I should be doing
> to improve this.
Yep, that's a lot better. There is still room for improvement
though:
Well I recently got re-motivated, by forgetting I was using an unpatched
version of Wine, and getting my WC3 campaign file nuked :(.
So, I've had a go over this all, and here is a new version. Is it a step
in the right direction? I still don't really know what I should be doing
to improve this.
On Thu, Nov 18, 2004 at 04:16:02PM +, Aneurin Price wrote:
> I don't really understand what it is you want, but I think I'm going to
> have to give up on this for the moment, until I get enough time to get
> more coding practice.
> Aneurin Price
If you don't mind, I will take up hacking it.
Alexandre Julliard wrote:
Aneurin Price <[EMAIL PROTECTED]> writes:
Any further comments on this?
Hard to say, that code is really painful to read. Please try to better
follow the coding conventions used in the rest of the code.
Apologies for long delay; I've been playing World of Warcraft for th
Aneurin Price <[EMAIL PROTECTED]> writes:
> Any further comments on this?
Hard to say, that code is really painful to read. Please try to better
follow the coding conventions used in the rest of the code.
--
Alexandre Julliard
[EMAIL PROTECTED]
Any further comments on this?
On Wed, 27 Oct 2004 23:13:13 +0100, you wrote:
> > * writing some regression tests to show your code is correct
>
> I still don't really know what I might test here. Maybe try examples of
> cases where the current code does not act like Windows; there are also
> some cases where neither acts li
Aneurin Price wrote:
I still don't really know what I might test here. Maybe try examples
of cases where the current code does not act like Windows; there are
also some cases where neither acts like windows (but they seem to have
the same problems). The problem is I probably wouldn't think of ca
Mike McCormack wrote:
Aneurin Price wrote:
Comments, anyone?
Looks like you've put quite a bit of effort into that. I think it's a
worthwhile effort, however, please consider:
* using a style more consistent with the rest of the Wine codebase
Could you elaborate on this point? I'm not sure to wh
I'm not sure if this is just Mozilla acting up but the patch doesn't
seem to be fully indented. Is this just UA wierdness?
Aneurin Price wrote:
Comments, anyone?
Aneurin Price wrote:
Comments, anyone?
Looks like you've put quite a bit of effort into that. I think it's a
worthwhile effort, however, please consider:
* using a style more consistent with the rest of the Wine codebase
* not abusing the preprocessor in printf.h,
* not writing C code in the head
12 matches
Mail list logo
