Re: winearts patch

2004-01-08 Thread Jeremy Shaw
At Wed, 7 Jan 2004 15:54:50 -0500, <[EMAIL PROTECTED]> wrote: > > > > (4b) wodPlayer_FeedDSP() > > > > > > In the while loop, I could not figure out the purpose of 'availInQ > > > > SPACE_THRESHOLD', so I changed it to 'availInQ'. In reality, the > > > SPACE_THRESHOLD check could probably be left

Re: winearts patch

2004-01-08 Thread Jeremy Shaw
At Wed, 07 Jan 2004 21:22:33 +0100, Eric Pouech wrote: > > Jeremy Shaw a écrit : > > Hello, > > > > This message is largely for Chris Morgan's review, but I thought I > > should open it to any interested parties. > > > > I have added wave-in support for arts. I also fixed some bugs in the > > wa

Re: Re: winearts patch

2004-01-07 Thread chmorgan
> > (4b) wodPlayer_FeedDSP() > > > > In the while loop, I could not figure out the purpose of 'availInQ > > > SPACE_THRESHOLD', so I changed it to 'availInQ'. In reality, the > > SPACE_THRESHOLD check could probably be left in, I am not sure what > > the purpose was in the first place. > Dunno eit

Re: winearts patch

2004-01-07 Thread Eric Pouech
Jeremy Shaw a écrit : Hello, This message is largely for Chris Morgan's review, but I thought I should open it to any interested parties. I have added wave-in support for arts. I also fixed some bugs in the waveout code, and made some "improvements". This code seems to work really well for me. If

Re: winearts patch

2004-01-05 Thread Jeremy Shaw
Hello, > (4d) Removed wodPlayer_DSPWait() > > I just calculate the wait value once in wodOpen() and store it in > wwo->dwSleepTime. > > Won't this value change as arts becomes filled with data or plays data out? No. The only function that calls wodPlayer_DSPWait() is the FeedDSP() -- and it on

Re: winearts patch

2004-01-05 Thread Chris Morgan
Just looking it over it seems fine. Eric Pouech is a better person to review something like this, he's had quite a bit more experence in this area. A couple of things: (4b) wodPlayer_FeedDSP() In the while loop, I could not figure out the purpose of 'availInQ > SPACE_THRESHOLD', so I changed i