Re: windowscodecs: Implement CreateBitmapFromHBITMAP.

2013-09-16 Thread Vincent Povirk
> Probably, but as the patch comment says the code is based on gdiplus > implementation, and there is no such an option flag in the corresponding > gdiplus API params. I'd suggest to accept the patch as as, and make further > improvements based on it. Fair enough, the patch looks good otherwise.

Re: windowscodecs: Implement CreateBitmapFromHBITMAP.

2013-09-16 Thread Dmitry Timoshkov
Vincent Povirk wrote: > Maybe the format for 32-bit bitmaps should be determined by the alpha > channel options? Probably, but as the patch comment says the code is based on gdiplus implementation, and there is no such an option flag in the corresponding gdiplus API params. I'd suggest to accept

Re: windowscodecs: Implement CreateBitmapFromHBITMAP.

2013-09-16 Thread Vincent Povirk
Maybe the format for 32-bit bitmaps should be determined by the alpha channel options? On Monday, September 16, 2013, Dmitry Timoshkov wrote: > Based on a gdiplus implementation. > --- > dlls/windowscodecs/imgfactory.c | 149 +- > dlls/windowscodecs/tests/bi