Re: windowscodecs: Add support for IMILBitmapSource interface.

2013-05-20 Thread Dmitry Timoshkov
Charles Davis wrote: > You're violating COM rules here: when you QI an object for an interface > pointer, the QI must always return the same result no matter what. Here, > however, you're returning this interface pointer in response to a query > for IUnknown, when the already-existing QueryInterf

Re: windowscodecs: Add support for IMILBitmapSource interface.

2013-05-20 Thread Charles Davis
On May 19, 2013, at 9:14 PM, Dmitry Timoshkov wrote: > diff --git a/dlls/windowscodecs/bitmap.c b/dlls/windowscodecs/bitmap.c > index f8904df..646f3a7 100644 > --- a/dlls/windowscodecs/bitmap.c > +++ b/dlls/windowscodecs/bitmap.c > @@ -446,6 +471,226 @@ static const IWICBitmapVtbl BitmapImpl_Vtbl

Re: windowscodecs: Add support for IMILBitmapSource interface.

2013-05-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25624 Your paranoid android