Re: msvcrt: remove hack

2013-05-30 Thread Henri Verbeet
On 30 May 2013 07:23, Austin English wrote: > and no modern gcc/other compiler that I can find cares. > It does if you add -Wunused-parameter, but then you'll get a lot of other warnings as well. IMO the "action = action;" line is pretty pointless and best just removed, though if people are just l

Re: msvcrt: remove hack

2013-05-30 Thread Joel Holdsworth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 30/05/13 12:56, Dmitry Timoshkov wrote: > Christian Costa wrote: > >> and no modern gcc/other compiler that I can find cares. > It was probably added because of a tool that warned of the > unused parameter ... So it all goes in circles

Re: msvcrt: remove hack

2013-05-30 Thread Christian Costa
Le 30/05/2013 13:56, Dmitry Timoshkov a écrit : Christian Costa wrote: and no modern gcc/other compiler that I can find cares. It was probably added because of a tool that warned of the unused parameter ... So it all goes in circles. ;) Ciao, Marcus So what about action = NULL instead?

Re: msvcrt: remove hack

2013-05-30 Thread Dmitry Timoshkov
Christian Costa wrote: > and no modern gcc/other compiler that I can find cares. > >>> It was probably added because of a tool that warned of the unused > >>> parameter ... So it all goes in circles. ;) > >>> > >>> Ciao, Marcus > >>> > >>> > >>> > >> So what about action = NULL instead? > >

Re: msvcrt: remove hack

2013-05-30 Thread Christian Costa
Le 30/05/2013 10:59, Dmitry Timoshkov a écrit : Christian Costa wrote: and no modern gcc/other compiler that I can find cares. It was probably added because of a tool that warned of the unused parameter ... So it all goes in circles. ;) Ciao, Marcus So what about action = NULL instead?

Re: msvcrt: remove hack

2013-05-30 Thread Dmitry Timoshkov
Christian Costa wrote: > >> and no modern gcc/other compiler that I can find cares. > > It was probably added because of a tool that warned of the unused > > parameter ... So it all goes in circles. ;) > > > > Ciao, Marcus > > > > > > > So what about action = NULL instead? A checker tool should

Re: msvcrt: remove hack

2013-05-30 Thread Christian Costa
Le 30/05/2013 09:54, Marcus Meissner a écrit : On Wed, May 29, 2013 at 10:23:29PM -0700, Austin English wrote: This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b but clang doesn't like it: clang -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_MT -D_REENTRA

Re: msvcrt: remove hack

2013-05-30 Thread Marcus Meissner
On Wed, May 29, 2013 at 10:23:29PM -0700, Austin English wrote: > This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b > > but clang doesn't like it: > clang -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ > -D_MT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasin