Re: I'm not sure why it was rejected

2013-10-02 Thread Vincent Povirk
> I guess if you SetLastError to not implemented you cannot return S_OK too It doesn't make sense to use SetLastError at all for functions returning HRESULT.

Re: I'm not sure why it was rejected

2013-10-02 Thread Marcus Meissner
On Wed, Oct 02, 2013 at 12:26:51PM -0300, Bruno Jesus wrote: > On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa wrote: > > I cannnot make sure my patch 99266 was rejected. > > I can't really tell why it was rejected but I can tell there are mixed > space/tabs in the SetLastError lines. > > I gues

Re: I'm not sure why it was rejected

2013-10-02 Thread Bruno Jesus
On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa wrote: > I cannnot make sure my patch 99266 was rejected. I can't really tell why it was rejected but I can tell there are mixed space/tabs in the SetLastError lines. I guess if you SetLastError to not implemented you cannot return S_OK too Try co