Mounir IDRASSI <[EMAIL PROTECTED]> writes:
> Hi Alexandre,
> The problem comes from the file cert.c in crypt32 dll (the real one, not
> the one in tests): at line 1976, the value AT_SIGNATURE is hardcoded in
> case for failure of CryptGetProvParam. Without my patch, this function
> definitely fail
>> This patch adds support for mandatory parameters in
>> RSAENH_CPGetProvParam. It also adds tests for them.
>> The mandatory parameters are: PP_UNIQUE_CONTAINER, PP_PROVTYPE,
>> PP_KEYSPEC, PP_KEYSET_TYPE, PP_KEYSTORAGE.
>>
>
> Thanks for
Mounir IDRASSI <[EMAIL PROTECTED]> writes:
> This patch adds support for mandatory parameters in
> RSAENH_CPGetProvParam. It also adds tests for them.
> The mandatory parameters are: PP_UNIQUE_CONTAINER, PP_PROVTYPE,
> PP_KEYSPEC, PP_KEYSET_TYPE, PP_KEYSTORAGE.
Thanks
Mounir IDRASSI <[EMAIL PROTECTED]> writes:
> From: Mounir IDRASSI <[EMAIL PROTECTED]>
> Date: Wed, 9 May 2007 03:33:45 +0200
> Subject: rsaenh: fix bug in RSAENH_CPGetProvParam
Could you please provide a more meaningful subject line to describe
your patch? "fix bug&qu
Hi Juan,
Thanks for your explanations. I'm resubmitting the patch.
Mounir IDRASSI
IDRIX - Cryptography and IT Security Experts
http://www.idrix.fr
Juan Lang wrote:
> Yes, certainly. See e.g. recent patches from Paul Vriens to get the tests
> succeeding on Win9x.
> --Juan
>
Hi again Mounir,
> For CRYPT_SEC_DESCR, my previous implementation of the patch tested for
> it with an "&" as you are suggesting. But, after Alexandre Julliard
> comment, I no more check the current version of windows and return
> always CRYPT_SEC_DESCR in RSAENH_CPGetP
For CRYPT_SEC_DESCR, my previous implementation of the patch tested for it with
an "&" as you are suggesting. But, after Alexandre Julliard comment, I no more
check the current version of windows and return always CRYPT_SEC_DESCR in
RSAENH_CPGetProvParam. So, that's why I put
Hi Mounir,
+case PP_KEYSTORAGE:
+dwTemp = CRYPT_SEC_DESCR;
This looks fine..
+result = CryptGetProvParam(prov, PP_KEYSTORAGE, (LPBYTE)&dwParam,
&dataLen, 0);
+ok(result && dataLen == sizeof(dwParam) && (dwParam ==
CRYPT_SEC_DESCR),
+"Expected CRYPT_SEC_DESCR t
Actually, the only application I know that uses this expects only
CRYPT_SEC_DESCR. So, as you advised, I'll rewrite the patch to remove
the version check.
Mounir IDRASSI
IDRIX - Cryptography and IT Security Experts
http://www.idrix.fr
Alexandre Julliard wrote:
> Mounir IDRASSI <[EMAIL PROTECTED]>
Mounir IDRASSI <[EMAIL PROTECTED]> writes:
> +case PP_KEYSTORAGE:
> +dwTemp = GetVersion();
> +/* for Windows NT, 95,98, Me, return CRYPT_PSTORE |
> CRYPT_UI_PROMPT | CRYPT_SEC_DESCR
> + * for the others, return CRYPT_SEC_DESCR
> + */
> +
On Mo, 2007-05-07 at 18:29 +0200, Mounir IDRASSI wrote:
> Thanks for your reply. I'm rewriting the patches and sending them back.
>
> Mounir IDRASSI
> IDRIX - Cryptography and IT Security Experts
> http://www.idrix.fr
>
> Detlef Riekenberg wrote:
> > I have no Idea about the code, but the missing
Thanks for your reply. I'm rewriting the patches and sending them back.
Mounir IDRASSI
IDRIX - Cryptography and IT Security Experts
http://www.idrix.fr
Detlef Riekenberg wrote:
> I have no Idea about the code, but the missing defines should
> be a seperate patch.
>
> Your idention looks broken.
>
On Sa, 2007-05-05 at 19:16 +0200, Mounir IDRASSI wrote:
> --- a/include/wincrypt.h
> +++ b/include/wincrypt.h
> +/* Values returned by CryptGetProvParam of PP_KEYSTORAGE */
> +#define CRYPT_SEC_DESCR 0x0001
> +#define CRYPT_PSTORE0x0002
> +#define CRYPT_UI_PROMPT
MAIL PROTECTED]>
Date: Sun, 6 May 2007 21:36:08 +0200
Subject: rsaenh: fix bugs in RSAENH_CPAcquireContext and RSAENH_CPGetProvParam
---
dlls/rsaenh/rsaenh.c | 32 ++-
dlls/rsaenh/tests/rsaenh.c | 61 ---
include/wincrypt.h
Mounir IDRASSI schreef:
> We have found few bugs in the MS Enhanced CSP implementation in wine
> (rsaenh.dll) and you'll find attached a patch that corrects them.
Hello Mounir,
Bug fixes are always welcome in wine.
But fixing bugs is one thing, but it is also very recommended to add
tests to verif
s the container for the local user, while it
should check the CRYPT_MACHINE_KEYSET flag to see if it should be
deleted on the local machine or for the local user.
- In RSAENH_CPGetProvParam: The following mandatory parameters were
not supported : PP_UNIQUE_CONTAINER, PP_PROVTYPE, PP_KEYSPEC,
PP_KEYSET
16 matches
Mail list logo
