Rob Shearman wrote:
There are a few HGDIOBJ casts as well as the already mentioned ALLOC_OBJ
macro. For example, in paint.c:
DeleteObject((HGDIOBJ)hbr);
Yes, both are HANDLEs, so they don't really need a cast. I've probably
written too much MFC code in my life :)
I've deleted all HGDIOB
Krzysztof Foltman wrote:
Rob Shearman wrote:
However, there are a few superfluous typecasts.
Any examples ?
There are a few HGDIOBJ casts as well as the already mentioned ALLOC_OBJ
macro. For example, in paint.c:
DeleteObject((HGDIOBJ)hbr);
In particular, please remove the ALLOC_OBJ
Rob Shearman wrote:
What is the ParaStyle structure used for? How does this relate to the
Style structure? Each character can have a different style, so why is
there a paragraph style?
Ahh, good news: the paragraph format structure (PARAFORMAT2) doesn't
need any precalculation (contrary to the c
Rob Shearman wrote:
No, the LocalAlloc/LocalFree/GlobalAlloc/GlobalFree functions are relics
from the old days of Win16. You should use HeapAlloc/HeapFree.
True.
Undo should be pretty easy as long as you can represent easily represent
user actions in a transactions stack.
Yes, I know the undo bas
Krzysztof Foltman wrote:
My rich text control is still far from even semi-complete, but I think
too much is done to start over, so I'm releasing it today. The number
one reason of its incompleteness is that I put more emphasis on making
things work exactly like in the original than on implementi
Krzysztof Foltman wrote:
Mike McCormack wrote:
It might be better to use libwineunicode and kernel32 unicode string
manipulation functions rather than msvcrt ones. eg lstrlenW,
lstrcpyW, etc. instead of wcslen, wcscpy, etc. Avoid the TCHAR type
in Wine code.
Good point. I guess it would be nice t
Mike McCormack wrote:
but I think the way forward is to submit an implementation of
dlls/riched20 then make that work, and after it's debugged and worked
out, rip out the old dlls/riched32 code and forward it to the new
completed riched20 code.
I'd prefer to keep it as an app, not a DLL for a wh
Krzysztof Foltman wrote:
My rich text control is still far from even semi-complete, but I think
too much is done to start over, so I'm releasing it today. The number
one reason of its incompleteness is that I put more emphasis on making
things work exactly like in the original than on implementi
My rich text control is still far from even semi-complete, but I think
too much is done to start over, so I'm releasing it today. The number
one reason of its incompleteness is that I put more emphasis on making
things work exactly like in the original than on implementing more
functions.
It's
