Re: RFC: detecting wine drivers in the audio tests

2008-05-01 Thread Stefan Dösinger
I just wanted to add that exactly the same problem exists with graphics drivers. There, we use approximately this scheme: -> If there's a driver difference, and both driver behaviors are somewhat sane, then we accept both results. An application couldn't depend on a specific result either -> I

Re: RFC: detecting wine drivers in the audio tests

2008-04-30 Thread Juan Lang
> I think that is an excellent idea and I can see it being immediately > useful in rpcrt4, if not other areas. Indeed, I also think it's an excellent idea. The crypt32 chain tests are another good candidate for this approach. --Juan

Re: RFC: detecting wine drivers in the audio tests

2008-04-30 Thread Robert Shearman
Francois Gouget wrote: > My idea is that > some platforms (e.g. Wine) could ask for stricter checks, by using > strict_wine a bit like they use todo_wine to request looser checks. > > So for instance you would do: > >strict_wine ok(expected_cond || buggy(this_is_a_bug), ...); > > Then on Wind

Re: RFC: detecting wine drivers in the audio tests

2008-04-30 Thread Francois Gouget
On Wed, 30 Apr 2008, Robert Reif wrote: [...] > I am suppling a minimal patch to the alsa driver and a single wave test to > illustrate this concept. I hope this allows valid tests to remain in spite of > buggy windows drivers. I think it should be a more general winetest concept. My idea is that

Re: RFC: detecting wine drivers in the audio tests

2008-04-30 Thread Alexandre Julliard
Robert Reif <[EMAIL PROTECTED]> writes: > The returned result of some audio functions on windows may be > inconsistent because a driver may actually supply the returned value. > > This presents a problem for the wine regression tests because a buggy > driver may return an unexpected result which c

Re: RFC: detecting wine drivers in the audio tests

2008-04-30 Thread Robert Reif
Maarten Lankhorst wrote: > Hello Robert, > > 2008/4/29 Robert Reif <[EMAIL PROTECTED]>: > >> The returned result of some audio functions on windows may be inconsistent >> because a driver may actually supply the returned value. >> >> This presents a problem for the wine regression tests because

Re: RFC: detecting wine drivers in the audio tests

2008-04-29 Thread Maarten Lankhorst
Hello Robert, 2008/4/29 Robert Reif <[EMAIL PROTECTED]>: > The returned result of some audio functions on windows may be inconsistent > because a driver may actually supply the returned value. > > This presents a problem for the wine regression tests because a buggy > driver may return an unexpec

Re: RFC: detecting wine drivers in the audio tests

2008-04-29 Thread Vitaliy Margolen
Robert Reif wrote: > The returned result of some audio functions on windows may be > inconsistent because a driver may actually supply the returned value. > > This presents a problem for the wine regression tests because a buggy > driver may return an unexpected result which causes the test to f

RFC: detecting wine drivers in the audio tests

2008-04-29 Thread Robert Reif
The returned result of some audio functions on windows may be inconsistent because a driver may actually supply the returned value. This presents a problem for the wine regression tests because a buggy driver may return an unexpected result which causes the test to fail. One way around this i