Re: RFC: HKCR merge implementation

2013-09-11 Thread André Hentschel
Am 11.09.2013 01:15, schrieb Juan Lang: > Hi George, > > On Tue, Sep 10, 2013 at 3:55 PM, George Stephanos > wrote: > > I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. > Feel free to comment. > So far, I've written code for all funct

RFC: HKCR merge implementation

2013-09-10 Thread George Stephanos
I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written code for all functions except for the RegEnum family. General description: HKCR handles are special. All wine handles have the two lowest bits zero'd. HKCR handles are masked. 10b spec

Re: RFC: HKCR merge implementation

2013-09-10 Thread George Stephanos
> > >> a couple bitwise nits in your first patch: > > +#define HKCR_MASK 2 > +#define IS_HKCR(hk) ((UINT_PTR)hk > 0 && ((UINT_PTR)hk & 3) == HKCR_MASK) > > Typically a mask would define all the bits that could be set, and a flag > would be the particular bit you want to test. Something like: > #def

Re: RFC: HKCR merge implementation

2013-09-10 Thread Juan Lang
Hi George, On Tue, Sep 10, 2013 at 3:55 PM, George Stephanos wrote: > I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel > free to comment. > So far, I've written code for all functions except for the RegEnum family. > > General description: > > HKCR handles are special. A

RFC: HKCR merge implementation

2013-09-10 Thread George Stephanos
I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written code for all functions except for the RegEnum family. General description: HKCR handles are special. All wine handles have the two lowest bits zero'd. HKCR handles are masked. 10b spec