RE: xinput: Add stub XInputEnable

2008-12-28 Thread ricardo filipe
yup, the patches look good on a quick glance. > Date: Mon, 29 Dec 2008 02:30:26 +0700 > From: andrewf...@gmail.com > To: hverb...@gmail.com; wine-de...@kievinfo.com; ricardo_barb...@hotmail.com > Subject: Re: xinput: Add stub XInputEnable >

Re: xinput: Add stub XInputEnable

2008-12-28 Thread Andrew Fenn
Sorry guys, that was a really bad patch I submitted much better ones to wine-patches already. [1/2] xinput: Added prototypes to header file [2/2] xinput: Added stub for XInputEnable

Re: xinput: Add stub XInputEnable

2008-12-28 Thread Henri Verbeet
2008/12/28 Andrew Fenn : > On Sun, Dec 28, 2008 at 9:39 PM, Henri Verbeet wrote: >> Also, don't forget to add the prototype to the header, I noticed they're >> missing for all the other xinput functions as well. > > I think I have added the prototypes correctly to the header file. > Could you hav

Re: xinput: Add stub XInputEnable

2008-12-28 Thread Vitaliy Margolen
Andrew Fenn wrote: > I think I have added the prototypes correctly to the header file. > Could you have a quick look at my patch and tell me if I am doing that > right? > > +XINPUT_CAPABILITIES* pCapabilities) Missing semicolon. Vitaliy.

RE: xinput: Add stub XInputEnable

2008-12-28 Thread ricardo filipe
q.org > Subject: Re: xinput: Add stub XInputEnable > > On Sun, Dec 28, 2008 at 9:39 PM, Henri Verbeet wrote: >> Also, don't forget to add the prototype to the header, I noticed they're >> missing for all the other xinput functions as well. > > I think I have ad

Re: xinput: Add stub XInputEnable

2008-12-28 Thread Andrew Fenn
On Sun, Dec 28, 2008 at 9:39 PM, Henri Verbeet wrote: > Also, don't forget to add the prototype to the header, I noticed they're > missing for all the other xinput functions as well. I think I have added the prototypes correctly to the header file. Could you have a quick look at my patch and tel

Re: xinput: Add stub XInputEnable

2008-12-28 Thread Henri Verbeet
2008/12/28 Andrew Fenn : > +void WINAPI XInputEnable(bool enable) Does this compile? "bool" is a C++ type. Also, don't forget to add the prototype to the header, I noticed they're missing for all the other xinput functions as well.