On Sat, 16 Feb 2008, Alexandre Julliard wrote:
> The test should probably be removed completely since there's already a
> default for it in the switch() that follows.
I was thinking of this, but wanted to go for the smaller patch initially,
but your wish is my command ;-).
Updated patch below.
Gerald Pfeifer <[EMAIL PROTECTED]> writes:
> @@ -109,7 +109,7 @@ BOOL WINAPI ILGetDisplayNameExW(LPSHELLF
> return FALSE;
> }
>
> -if (type >= 0 && type <= 2)
> +if (type <= 2)
> {
> switch (type)
> {
The test should probably be removed completel
> From: Michael Jung
>
> SHBindToParent does not allocate a
> new PIDL for pidlLast, but returns a pointer to right
> location in pidl. This means you should not free it.
> There's still the problem that the shell folder isn't
> released in failure cases.
>
> Sorry, I didn't realize this.
I
Hi Ge,
On Saturday 13 August 2005 20:55, Ge van Geldorp wrote:
> dwAttributes = SFGAO_FILESYSTEM;
> hr = IShellFolder_GetAttributesOf(psfFolder, 1, &pidlLast,
> &dwAttributes); -if (FAILED(hr) || !(dwAttributes & SFGAO_FILESYSTEM))
> return FALSE; +if (FAILED(hr) || !(dwAttribute