Hi,
--- Robert Reif <[EMAIL PROTECTED]> wrote:
> New patch with tests and credit to ReactOS. I don't know who wrote
> the code and the credit is not in the file. The Author column of the
> CVSweb page lists jimtabor. Please let me know if this is adequate
> credit or not. It would be nice if
--- Dmitry Timoshkov <[EMAIL PROTECTED]> wrote:
> It's sad to say that, but unfortunately that's not the case on the ReactOS
> side sometimes, especially for Wine code borrowed at the early stage.
Sometimes but if you point out where and I am happy to fix it.
Thanks
Steven
___
> From: Dmitry Timoshkov
>
> "Steven Edwards" <[EMAIL PROTECTED]> wrote:
> > Its nice to note where the code came from. We always try to
> > do it in ReactOS so please credit Jim for his advpack function.
>
> It's sad to say that, but unfortunately that's not the case
> on the ReactOS side some
Dmitry Timoshkov wrote:
"Steven Edwards" <[EMAIL PROTECTED]> wrote:
--- Robert Reif <[EMAIL PROTECTED]> wrote:
Some of the new code was borrowed from reactos. GetVersionFromFile*
Its nice to note where the code came from. We always try to do it in ReactOS so please credit Jim
for his
"Steven Edwards" <[EMAIL PROTECTED]> wrote:
> --- Robert Reif <[EMAIL PROTECTED]> wrote:
> > Some of the new code was borrowed from reactos. GetVersionFromFile*
>
> Its nice to note where the code came from. We always try to do it in ReactOS
> so please credit Jim
> for his advpack function.
It
--- Robert Reif <[EMAIL PROTECTED]> wrote:
> Some of the new code was borrowed from reactos. GetVersionFromFile*
Its nice to note where the code came from. We always try to do it in ReactOS so
please credit Jim
for his advpack function.
Thanks
Steven
___
Rob Shearman wrote:
I think you forgot to include the tests.
Rob
Past my bed time.
diff -u -N wine.cvs/dlls/advpack/tests/advpack.c
wine/dlls/advpack/tests/advpack.c
--- wine.cvs/dlls/advpack/tests/advpack.c 1969-12-31 19:00:00.0
-0500
+++ wine/dlls/advpack/tests/advpack.c 2005-01
Robert Reif wrote:
Robert Reif wrote:
Add stubs for NeedReboot and NeedRebootInit.
without FIXME bug
This time with three more functions implemented and some tests.
Some of the new code was borrowed from reactos. GetVersionFromFile*
is badly broken in reactos so I don't really trust IsNTAdmin. I
o
Robert Reif wrote:
Add stubs for NeedReboot and NeedRebootInit.
without FIXME bug
Index: dlls/advpack/advpack.c
===
RCS file: /home/wine/wine/dlls/advpack/advpack.c,v
retrieving revision 1.6
diff -u -r1.6 advpack.c
--- dlls/advpack/adv
