Re: TreeView fix endless loop and colors with custom draw

2005-04-16 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > + if (((tvItem->mask & TVIF_CHILDREN ) && (originalItem.cChildren > != wineItem->cChildren ) ) || > + ((tvItem->mask & TVIF_IMAGE) && (originalItem.iImage > != wineItem->iImage)&& > + wineI

Re: Treeview plus/minus

2005-03-24 Thread Jon Griffiths
Hi George, >If I change the size to 18 the plus is drawn correctly >Does anybody knows anything about this ? The native controls draw a different kind of cross for large items, which looks a lot nicer. I added this but the initial threshold for deciding when to draw the large cross was too small,

RE: Treeview +/-

2004-12-02 Thread Ge van Geldorp
> From: Jon Griffiths > > >Maybe the height/width at which to switch to the Rectangle drawing > >algorithm needs a bit of tuning? > > Ge, Can you confirm this fixes the size for you? It works for > me if I change my system font to a larger one... Yes, this works for me. Thanks. Ge van Geldorp

RE: Treeview +/-

2004-10-21 Thread Ge van Geldorp
> From: Jon Griffiths > > Hi, > > Fixing my own FIXME. > > Cheers, > Jon > >+wine/dlls/comctl32/treeview.c > Draw +/- correctly for large icon sizes (patch applied here: http://www.winehq.org/hypermail/wine-cvs/2004/10/0115.html) I can see that this would be an improvement for large i

Re: TreeView control - set correct hwndNotify

2003-09-22 Thread Alexandre Julliard
"Igor Grahek" <[EMAIL PROTECTED]> writes: > Is there a reason why this is not accepted? > > ChangeLog: - TreeView control set Notify window correctly in case that > window style is WS_POPUP. I still don't think the IsWindow thing is correct. Have you checked what Windows does in that case? -- A

RE: TreeView control - set correct hwndNotify

2003-09-11 Thread Igor Grahek
fy == HWND_MESSAGE) +infoPtr->hwndNotify = GetParent(hwnd); but not removed. Igor > -Original Message- > From: Alexandre Julliard [mailto:[EMAIL PROTECTED] > Sent: September 10, 2003 6:31 PM > To: Igor Grahek > Cc: [EMAIL PROTECTED] > Subject: Re: TreeView control

Re: TreeView control - set correct hwndNotify

2003-09-10 Thread Alexandre Julliard
"Igor Grahek" <[EMAIL PROTECTED]> writes: > +infoPtr->hwndNotify = lpcs->hwndParent; > +if(!IsWindow(infoPtr->hwndNotify)) > +infoPtr->hwndNotify = GetParent(hwnd); Why do you need the IsWindow() check? AFAICS the parent should always be valid (or possibly 0 but then GetParent()

RE: TreeView control - set correct hwndNotify

2003-09-09 Thread Dimitrie O. Paun
On Tue, 9 Sep 2003, Igor Grahek wrote: > Do you think something like this will do? Yes, this looks much better. > I also checked some other controls in comctl32 and every implementation > is different. Usualy there is no hwndNotify and GetParent() is used in > SendMessageW calls and all of these

RE: TreeView control - set correct hwndNotify

2003-09-09 Thread Igor Grahek
replaced. Luckily most of control implementations are already forwarding lpcs to *_Create functions. Igor > -Original Message- > From: Dimitrie O. Paun [mailto:[EMAIL PROTECTED] > Sent: September 9, 2003 10:35 AM > To: Igor Grahek > Cc: [EMAIL PROTECTED] > Subject: RE:

RE: TreeView control - set correct hwndNotify

2003-09-09 Thread Dimitrie O. Paun
On Tue, 9 Sep 2003, Igor Grahek wrote: > I'm pretty new at Wine patching and CreateWindowEx does some other > parent checking so I didn't want to break anything else by fixing this > one. Yes, but this solution just looks to ugly to be propagated to the other controls. Let's find a nice one that

RE: TreeView control - set correct hwndNotify

2003-09-09 Thread Igor Grahek
EMAIL PROTECTED]; Igor Grahek > Subject: Re: TreeView control - set correct hwndNotify > > > On September 8, 2003 03:52 pm, Igor Grahek wrote: > > ChangeLog: - TreeView control set Notify window correctly > in case that > > window style is WS_POPUP. > > Please

Re: TreeView control - set correct hwndNotify

2003-09-08 Thread Dimitrie O. Paun
On September 8, 2003 03:52 pm, Igor Grahek wrote: > ChangeLog: - TreeView control set Notify window correctly in case that > window style is WS_POPUP. Please send unidiff patches: http://www.winehq.org/site/sending_patches > ! if ((infoPtr->dwStyle & (WS_CHILD|WS_POPUP)) == WS_POPUP && >

RE: TreeView & WM_NOTIFY

2003-09-08 Thread Igor Grahek
> Sent: September 5, 2003 4:50 PM > To: '[EMAIL PROTECTED]' > Subject: RE: TreeView & WM_NOTIFY > > > It looks like comctl32.dll is seting up some hooks to forward > messages to requested window because even if you use --dll > comctl32=n the owner is set up

RE: TreeView & WM_NOTIFY

2003-09-05 Thread Igor Grahek
c I tried to figure out what is going on with hooks but I don't have much experience with windows hooks so I will appreciate any help. Thanks, Igor > -Original Message- > From: Igor Grahek [mailto:[EMAIL PROTECTED] > Sent: September 5, 2003 11:29 AM > To: '[EMAIL

RE: TreeView & WM_NOTIFY

2003-09-04 Thread Igor Grahek
, 2003 6:42 PM > To: Igor Grahek > Cc: [EMAIL PROTECTED] > Subject: Re: TreeView & WM_NOTIFY > > > On Tue, 2 Sep 2003, Igor Grahek wrote: > > > My problem is very similar to bug 1227 > > (http://bugs.winehq.org/show_bug.cgi?id=1227) > > Treeview in app

Re: TreeView & WM_NOTIFY

2003-09-02 Thread Dimitrie O. Paun
On Tue, 2 Sep 2003, Igor Grahek wrote: > My problem is very similar to bug 1227 > (http://bugs.winehq.org/show_bug.cgi?id=1227) > Treeview in application is sending WM_NOTIFY on double click (NM_DBLCLK) > to the wrong > Window handle. GetParent() function returns handle to the root window > and ro