RE: Pipeline separation preview

2008-07-06 Thread Stefan Dösinger
> Looks good to me. You should probably start submitting it bit by bit, > see if any regression come up, although it looks pretty safe to me. Sure, that's the plan. I don't think submitting 50+ patches at once will work well. I have found 2 minor regressions, but fixed them already in my tree. (Mo

Re: Pipeline separation preview

2008-07-06 Thread H. Verbeet
Looks good to me. You should probably start submitting it bit by bit, see if any regression come up, although it looks pretty safe to me.

RE: Pipeline separation preview

2008-07-05 Thread Stefan Dösinger
> -Original Message- > From: [EMAIL PROTECTED] [mailto:wine-devel- > [EMAIL PROTECTED] On Behalf Of Ivan Gyurdiev Thanks for the review! > I think it's moving in the right direction. It's also important that > you've tried this on the NV extension, since now you have two pipeline > repla

Re: Pipeline separation preview

2008-07-05 Thread Ivan Gyurdiev
Stefan Dösinger wrote: > Oops, forgot to attach the archive > I like it, especially these parts: - Interface decoupling - Moves FFP replacement code to using the FFP state table interface, instead of touching the unrelated shader interface - Code separation - Code unrelated to shaders is moved

RE: Pipeline separation preview

2008-07-05 Thread Stefan Dösinger
Hi, Here is an updated patchset. I have CC'ed Henri and Ivan, since they were the main critics of the old design. Ivan, this should get rid of the inheritance thunks the old way of munging everything into the shader backend had. I've discussed things with Henri on IRC. Henri, can you take a quick l

RE: Pipeline separation preview

2008-07-02 Thread Stefan Dösinger
Oops, sorry, I did not intend to send it 4 times. I had some disagreements with my glourious Outlook 2007 "mail client". > -Original Message- > From: [EMAIL PROTECTED] [mailto:wine-devel- > [EMAIL PROTECTED] On Behalf Of Stefan Dösinger > Sent: Wednesday, July 02, 2008 10:48 AM > To: wine