"Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
> Could you take a look at this fix? I would think I have resolved the other
> issue with SetDefButton as well. Tests with msg ran fine.
The only thing that I'd suggest to remove is a misleading comment
about WM_NCCREATE, otherwise the patch looks
04 1:35 PM
> To: Santosh Siddheshwar; Alexandre Julliard
> Cc: Robert Shearman; [EMAIL PROTECTED]
> Subject: Re: Handling dialog messages for non-template based dialogs
>
> "Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
>
> > This test fails with WINE even
"Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
> This test fails with WINE even after I create the DIALOGINFO structure the
> first time it enters DefDlgProc. Not sure why this test should work on
> Windows.
Since I wrote it under Windows it apparently works there.
> Basically at the stage whe
Siddheshwar; Alexandre Julliard
> Cc: Robert Shearman; [EMAIL PROTECTED]
> Subject: Re: Handling dialog messages for non-template based dialogs
>
> "Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
>
> > OK.One place where this could be done is WM_NCCRE
> Sent: Thursday, April 15, 2004 3:56 PM
> To: Santosh Siddheshwar; Alexandre Julliard
> Cc: Robert Shearman; [EMAIL PROTECTED]
> Subject: Re: Handling dialog messages for non-template based dialogs
>
> "Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
>
&
"Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
> OK.One place where this could be done is WM_NCCREATE which comes before
> WM_CREATE. Other place (possibly better) where it might be possible to do
> this is in CBTProc hook procedure. Not sure about the second option though.
> Any thoughts?
I'll
age-
> From: Alexandre Julliard [SMTP:[EMAIL PROTECTED]
> Sent: Thursday, April 15, 2004 9:43 AM
> To: Santosh Siddheshwar
> Cc: Dmitry Timoshkov; Robert Shearman; [EMAIL PROTECTED]
> Subject: Re: Handling dialog messages for non-template based dialogs
>
> Santosh Siddh
Santosh Siddheshwar <[EMAIL PROTECTED]> writes:
> But dont you think that the structure is not really required till the
> window has been created successfully?
Well, I don't think so, but the only way to know for sure is to write
a test program under Windows to determine the exact behavior.
--
moshkov
> Cc: Santosh Siddheshwar; Robert Shearman; [EMAIL PROTECTED]
> Subject: Re: Handling dialog messages for non-template based dialogs
>
> "Dmitry Timoshkov" <[EMAIL PROTECTED]> writes:
>
> > Yes, if Alexandre has no objections. Be patient, that
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes:
> Yes, if Alexandre has no objections. Be patient, that may take some time.
Actually, I do have an objection... I think you should be allocating
the structure as soon as it is needed, WM_CREATE is not the first
message that the window will receive.
"Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
> So can I expect this to be checked into cvs soon?
Yes, if Alexandre has no objections. Be patient, that may take some time.
--
Dmitry.
; Subject: Re: Handling dialog messages for non-template based dialogs
>
> "Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
>
> > Thanks for the feedback. Excellent catches! Hope my next mail to
> > wine-patches gets through!
>
> Your new patch loo
"Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
> Thanks for the feedback. Excellent catches! Hope my next mail to
> wine-patches gets through!
Your new patch looks good for me. Thanks for doing this work!
--
Dmitry.
rman; [EMAIL PROTECTED]
> Cc: [EMAIL PROTECTED]
> Subject: Re: Handling dialog messages for non-template based dialogs
>
> "Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
>
> > I didnt get the second point that you mention
> > Another one might be
"Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
> I didnt get the second point that you mention
> Another one might be that WM_CREATE must be always
> passed to DEFDLG_Proc regardless of what result an application
> returned to DefDlgProc16/A/W.
Here is a snippet of DefDlgProc16 (DefDlgProcA/W
Dmitry Timoshkov [SMTP:[EMAIL PROTECTED]
> Sent: Tuesday, April 13, 2004 5:46 PM
> To: Robert Shearman; [EMAIL PROTECTED]
> Cc: [EMAIL PROTECTED]
> Subject: Re: Handling dialog messages for non-template based dialogs
>
> "Robert Shearman" <[EMAIL PROTECTED]> wr
"Robert Shearman" <[EMAIL PROTECTED]> wrote:
> > +if (!(dlgInfo = HeapAlloc( GetProcessHeap(), 0,
> sizeof(*dlgInfo) ))) return 0;
>
> Minor point, but you probably want to return -1 here to say that window
> creation failed.
Good catch. Another one might be that WM_CREATE must be al
Santosh Siddheshwar wrote:
>
> Change Log:
> windows/defdlg.c - Added code for allocating DIALOGINFO structure and
> storing it as an attribute of the window
> windows/dialog.c - Removed code for allocating DIALOGINFO structure and
> moved initialization of DIALOGINFO structure
> to after CreateWin
e: Handling dialog messages for non-template based dialogs
>
> "Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
>
> > Change Log:
> > windows/defdlg.c - Added code for allocating DIALOGINFO structure and
> > storing it as an attribute of the window
"Santosh Siddheshwar" <[EMAIL PROTECTED]> wrote:
> Change Log:
> windows/defdlg.c - Added code for allocating DIALOGINFO structure and
> storing it as an attribute of the window
> windows/dialog.c - Removed code for allocating DIALOGINFO structure and
> moved initialization of DIALOGINFO structure
20 matches
Mail list logo
